Chromium Code Reviews
Help | Chromium Project | Sign in
(778)

Issue 16184002: REGRESSION: Select listbox dispatches a change event on scroll. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months ago by tkent
Modified:
10 months, 4 weeks ago
Reviewers:
keishi1
CC:
blink-reviews_chromium.org, eae+blinkwatch_chromium.org, adamk+blink_chromium.org
Visibility:
Public.

Description

REGRESSION: Select listbox dispatches a change event on scroll.

wkrev.com/143560 fixed mouse events on scrollbars, and broke an
HTMLSelectElement assumption that mouseup event always happens on an
<option> element. So, listBoxOnChange() was called unexpectedly.

This patch avoids this problem by checking
m_lastOnChangeSelection.isEmpty(), which means we didn't start click
or drag in this <select> element.

BUG=244406
TEST=automated
R=keishi@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Lint Patch
A LayoutTests/fast/forms/select/listbox-click-on-scrollbar.html View 1 chunk +41 lines, -0 lines 0 comments ? errors Download
A + LayoutTests/fast/forms/select/listbox-click-on-scrollbar-expected.txt View 1 chunk +3 lines, -3 lines 0 comments ? errors Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 5
tkent
11 months ago #1
keishi1
On 2013/05/29 05:23:31, tkent wrote: lgtm
11 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/16184002/1
10 months, 4 weeks ago #3
I haz the power (commit-bot)
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7536
10 months, 4 weeks ago #4
tkent
10 months, 4 weeks ago #5
Message was sent while issue was closed.
Committed patchset #1 manually as r151430 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6