Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1629693002: Add missing closing namespace comments to wtf. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
danakj, sof
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, jshin+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing closing namespace comments to wtf. clang-format strips the newline before the closing '}' of a namespace if there is no namespace comment. Since we want these comments anyhow, just add them. Patch created by running: # create compile_commands.json for clang-tidy: cd src ninja -C out/Release/ -t compdb objcxx cxx > compile_commands.json # run clang-tidy check for adding namespace comments: cd out/Release ~/src/llvm-rw/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -checks=-*,google-readability-namespace-comments -p ../.. \ -clang-tidy-binary ~/src/llvm-build/bin/clang-tidy -fix \ third_party/WebKit/Source/wtf I then manually reverted changes to two base headers due to http://llvm.org/PR26274 No behavior change. BUG=580787, 403854 Committed: https://crrev.com/e714969004e905e8692366005b672a7edd8d13a8 Cr-Commit-Position: refs/heads/master@{#371143}

Patch Set 1 #

Patch Set 2 : PR26274 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M third_party/WebKit/Source/wtf/ASCIICType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ASCIICType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ASCIICTypeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/AddressSpaceRandomization.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/ArrayBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ArrayBufferView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/CheckedArithmetic.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ConditionalDestructor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/CryptographicallyRandomNumber.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Forward.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Locker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/SizeLimits.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/TemporaryChange.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/TreeNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/testing/WTFTestPrintersTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/Collator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringHash.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImplCF.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImplMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringStatics.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringView.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
Nico
dcheng: using clang-tidy instead of your run_clang_tool script seems to work fairly well. I forgot ...
4 years, 11 months ago (2016-01-23 17:37:30 UTC) #4
dcheng
On 2016/01/23 at 17:37:30, thakis wrote: > dcheng: using clang-tidy instead of your run_clang_tool script ...
4 years, 11 months ago (2016-01-23 17:48:11 UTC) #6
Nico
On 2016/01/23 17:48:11, dcheng wrote: > On 2016/01/23 at 17:37:30, thakis wrote: > > dcheng: ...
4 years, 11 months ago (2016-01-23 18:00:06 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1629693002/10001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1629693002/10001
4 years, 11 months ago (2016-01-23 19:10:03 UTC) #9
sof
lgtm (non wtf/ owner, but looks all around consistent.)
4 years, 11 months ago (2016-01-23 19:21:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1629693002/10001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1629693002/10001
4 years, 11 months ago (2016-01-23 20:26:21 UTC) #14
dcheng
On 2016/01/23 at 18:00:06, thakis wrote: > On 2016/01/23 17:48:11, dcheng wrote: > > On ...
4 years, 11 months ago (2016-01-23 22:13:17 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 11 months ago (2016-01-23 23:19:12 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-23 23:21:17 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e714969004e905e8692366005b672a7edd8d13a8
Cr-Commit-Position: refs/heads/master@{#371143}

Powered by Google App Engine
This is Rietveld 408576698