PaintInvalidationState::enclosingSelfPaintingLayer()

PaintInvalidationState::enclosingSelfPaintingLayer()

It was PaintInvalidationState::enclosingLayer(), but we actually need
the enclosing self painting layer to set repaint flags. Later changes
to optimize empty paint phases also need enclosing self painting layer.

We don't need to specially handle multicol spanner in the new function
because our paint invalidation of multicol spanner follows the true
layer painting order. Instead we need to special handle multicol
spanner in the assertion to check if the repaint flags are properly
set on layers.

This has been reviewed by mstensho@opera.com and chrishtr@chromium.org
as part of https://codereview.chromium.org/1584493002/.

TBR=mstensho@opera.com,chrishtr@chromium.org
BUG=574938
Committed: https://crrev.com/a6c054a66a5365513c6023206dc9eecbbe4f1641
Cr-Commit-Position: refs/heads/master@{#371475}

[Xianzhu, 2016-01-23 02:03:56]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-01-23 02:03:56]

This is separated from the outline-phase-optimization CL
(https://codereview.chromium.org/1584493002/).

[Xianzhu, 2016-01-25 18:37:42]

Description was changed from

==========
PaintInvalidationState::enclosingSelfPaintingLayer()

It was PaintInvalidationState::enclosingLayer(), but we actually need
the enclosing self painting layer to set repaint flags. Later changes
to optimize empty paint phases also need enclosing self painting layer.

We don't need to specially handle multicol spanner in the new function
because our paint invalidation of multicol spanner follows the true
layer painting order. Instead we need to special handle multicol
spanner in the assertion to check if the repaint flags are properly
set on layers.

BUG=574938
==========

to

==========
PaintInvalidationState::enclosingSelfPaintingLayer()

It was PaintInvalidationState::enclosingLayer(), but we actually need
the enclosing self painting layer to set repaint flags. Later changes
to optimize empty paint phases also need enclosing self painting layer.

We don't need to specially handle multicol spanner in the new function
because our paint invalidation of multicol spanner follows the true
layer painting order. Instead we need to special handle multicol
spanner in the assertion to check if the repaint flags are properly
set on layers.

This has been reviewed by mstensho@opera.com and chrishtr@chromium.org
as part of https://codereview.chromium.org/1584493002/.

TBR=mstensho@opera.com,chrishtr@chromium.org
BUG=574938
==========

[Xianzhu, 2016-01-26 06:03:38]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-01-26 06:07:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1629563003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1629563003/1

[commit-bot: I haz the power, 2016-01-26 08:15:12]

Description was changed from

==========
PaintInvalidationState::enclosingSelfPaintingLayer()

It was PaintInvalidationState::enclosingLayer(), but we actually need
the enclosing self painting layer to set repaint flags. Later changes
to optimize empty paint phases also need enclosing self painting layer.

We don't need to specially handle multicol spanner in the new function
because our paint invalidation of multicol spanner follows the true
layer painting order. Instead we need to special handle multicol
spanner in the assertion to check if the repaint flags are properly
set on layers.

This has been reviewed by mstensho@opera.com and chrishtr@chromium.org
as part of https://codereview.chromium.org/1584493002/.

TBR=mstensho@opera.com,chrishtr@chromium.org
BUG=574938
==========

to

==========
PaintInvalidationState::enclosingSelfPaintingLayer()

It was PaintInvalidationState::enclosingLayer(), but we actually need
the enclosing self painting layer to set repaint flags. Later changes
to optimize empty paint phases also need enclosing self painting layer.

We don't need to specially handle multicol spanner in the new function
because our paint invalidation of multicol spanner follows the true
layer painting order. Instead we need to special handle multicol
spanner in the assertion to check if the repaint flags are properly
set on layers.

This has been reviewed by mstensho@opera.com and chrishtr@chromium.org
as part of https://codereview.chromium.org/1584493002/.

TBR=mstensho@opera.com,chrishtr@chromium.org
BUG=574938
==========

[commit-bot: I haz the power, 2016-01-26 08:15:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 08:16:33]

Description was changed from

==========
PaintInvalidationState::enclosingSelfPaintingLayer()

It was PaintInvalidationState::enclosingLayer(), but we actually need
the enclosing self painting layer to set repaint flags. Later changes
to optimize empty paint phases also need enclosing self painting layer.

We don't need to specially handle multicol spanner in the new function
because our paint invalidation of multicol spanner follows the true
layer painting order. Instead we need to special handle multicol
spanner in the assertion to check if the repaint flags are properly
set on layers.

This has been reviewed by mstensho@opera.com and chrishtr@chromium.org
as part of https://codereview.chromium.org/1584493002/.

TBR=mstensho@opera.com,chrishtr@chromium.org
BUG=574938
==========

to

==========
PaintInvalidationState::enclosingSelfPaintingLayer()

It was PaintInvalidationState::enclosingLayer(), but we actually need
the enclosing self painting layer to set repaint flags. Later changes
to optimize empty paint phases also need enclosing self painting layer.

We don't need to specially handle multicol spanner in the new function
because our paint invalidation of multicol spanner follows the true
layer painting order. Instead we need to special handle multicol
spanner in the assertion to check if the repaint flags are properly
set on layers.

This has been reviewed by mstensho@opera.com and chrishtr@chromium.org
as part of https://codereview.chromium.org/1584493002/.

TBR=mstensho@opera.com,chrishtr@chromium.org
BUG=574938

Committed: https://crrev.com/a6c054a66a5365513c6023206dc9eecbbe4f1641
Cr-Commit-Position: refs/heads/master@{#371475}
==========

[commit-bot: I haz the power, 2016-01-26 08:16:34]

Patchset 1 (id:??) landed as
https://crrev.com/a6c054a66a5365513c6023206dc9eecbbe4f1641
Cr-Commit-Position: refs/heads/master@{#371475}