[Reland] Fix org.chromium.chrome.browser.GeolocationTest

[Reland] Fix org.chromium.chrome.browser.GeolocationTest

The geolocation tests did not work because:
- They referred to incorrect test pages.
  Correct test pages:
    https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_on_load.html
    https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_watch_on_load.html
- A race condition was causing LocationProviderAdapter.newLocationAvailable() to
  be often called prior to LocationProviderFactory.LocationProvider.start().

In addition to fixing the above problems, this CL makes
org.chromium.chrome.browser.GeolocationTest more similar to
- org.chromium.android_webview.test.GeolocationTest
- org.chromium.content.browser.ContentViewLocationTest
In particular, all of the tests now:
- Use the same test page
- Use MockLocationProvider

BUG=141518
Test=Less flakiness

Committed: https://crrev.com/54d1c1e5d856c74aa0394cbf0fd1f30e63708702
Cr-Commit-Position: refs/heads/master@{#371257}

[pkotwicz, 2016-01-22 22:39:47]

pkotwicz@chromium.org changed reviewers:
+ tedchoc@chromium.org

[pkotwicz, 2016-01-22 22:39:47]

tedchoc@ can you please take a look?

Patch set #1 has the CL as it landed in
https://codereview.chromium.org/1599113002/

Notable changes:
- Calling LocationSettingsTestUtil.setSystemLocationSettingEnabled() in setup().
This was done to fix the flakiness in other geolocation tests. See
https://codereview.chromium.org/855543004
- Leaving the tests annotated as flaky so that I can watch the bots over the
next couple of days and verify that the flakiness is gone

[Ted C, 2016-01-22 23:37:02]

lgtm

[pkotwicz, 2016-01-25 15:57:50]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-01-25 15:58:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1629543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1629543002/20001

[commit-bot: I haz the power, 2016-01-25 17:39:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-25 17:40:39]

Description was changed from

==========
[Reland] Fix org.chromium.chrome.browser.GeolocationTest

The geolocation tests did not work because:
- They referred to incorrect test pages.
  Correct test pages:
   
https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android...
   
https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android...
- A race condition was causing LocationProviderAdapter.newLocationAvailable() to
  be often called prior to LocationProviderFactory.LocationProvider.start().

In addition to fixing the above problems, this CL makes
org.chromium.chrome.browser.GeolocationTest more similar to
- org.chromium.android_webview.test.GeolocationTest
- org.chromium.content.browser.ContentViewLocationTest
In particular, all of the tests now:
- Use the same test page
- Use MockLocationProvider

BUG=141518
Test=Less flakiness
==========

to

==========
[Reland] Fix org.chromium.chrome.browser.GeolocationTest

The geolocation tests did not work because:
- They referred to incorrect test pages.
  Correct test pages:
   
https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android...
   
https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android...
- A race condition was causing LocationProviderAdapter.newLocationAvailable() to
  be often called prior to LocationProviderFactory.LocationProvider.start().

In addition to fixing the above problems, this CL makes
org.chromium.chrome.browser.GeolocationTest more similar to
- org.chromium.android_webview.test.GeolocationTest
- org.chromium.content.browser.ContentViewLocationTest
In particular, all of the tests now:
- Use the same test page
- Use MockLocationProvider

BUG=141518
Test=Less flakiness

Committed: https://crrev.com/54d1c1e5d856c74aa0394cbf0fd1f30e63708702
Cr-Commit-Position: refs/heads/master@{#371257}
==========

[commit-bot: I haz the power, 2016-01-25 17:40:40]

Patchset 2 (id:??) landed as
https://crrev.com/54d1c1e5d856c74aa0394cbf0fd1f30e63708702
Cr-Commit-Position: refs/heads/master@{#371257}