Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 855543004: [Android] Fix geolocation infobar tests (Closed)

Created:
5 years, 11 months ago by newt (away)
Modified:
5 years, 11 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix geolocation infobar tests These tests now mock out the system location setting as being enabled, which allows them to succeed even on devices where system location is disabled. BUG=449341 Committed: https://crrev.com/aac03830c5940164c7beab7142a4ed444f35bef7 Cr-Commit-Position: refs/heads/master@{#311857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -38 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 5 chunks +11 lines, -18 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/location/LocationSettingsTestUtil.java View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ContentPreferencesTest.java View 3 chunks +2 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 11 months ago (2015-01-16 01:13:13 UTC) #2
nyquist
lgtm
5 years, 11 months ago (2015-01-16 07:20:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855543004/1
5 years, 11 months ago (2015-01-16 07:21:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 08:19:30 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 08:20:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aac03830c5940164c7beab7142a4ed444f35bef7
Cr-Commit-Position: refs/heads/master@{#311857}

Powered by Google App Engine
This is Rietveld 408576698