Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1629403004: Remove all descendant views from AXAuraObjCache when a view is removed. (Closed)

Created:
4 years, 11 months ago by dmazzoni
Modified:
4 years, 10 months ago
Reviewers:
David Tseng, sky
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all descendant views from AXAuraObjCache when a view is removed. BUG=581426 Committed: https://crrev.com/6c4af2f35251aad93cb80f3cfdd4c38d3a616719 Cr-Commit-Position: refs/heads/master@{#372453}

Patch Set 1 #

Patch Set 2 : git cl format #

Patch Set 3 : Only compile unit tests on aura platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -13 lines) Patch
M ui/views/accessibility/ax_aura_obj_cache.h View 2 chunks +6 lines, -5 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 2 chunks +5 lines, -7 lines 0 comments Download
A ui/views/accessibility/ax_aura_obj_cache_unittest.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Messages

Total messages: 11 (4 generated)
dmazzoni
4 years, 11 months ago (2016-01-26 19:47:15 UTC) #2
David Tseng
lgtm
4 years, 11 months ago (2016-01-26 22:59:17 UTC) #3
sky
I believe you just need for the gyp changes, LGTM
4 years, 11 months ago (2016-01-27 02:42:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1629403004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1629403004/40001
4 years, 10 months ago (2016-01-29 22:19:53 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-29 23:11:47 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6c4af2f35251aad93cb80f3cfdd4c38d3a616719 Cr-Commit-Position: refs/heads/master@{#372453}
4 years, 10 months ago (2016-01-29 23:13:27 UTC) #10
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-01 09:32:10 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1655773002/ by jochen@chromium.org.

The reason for reverting is: fails on lsan bot:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2....

Powered by Google App Engine
This is Rietveld 408576698