Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: ui/views/accessibility/ax_aura_obj_cache.h

Issue 1629403004: Remove all descendant views from AXAuraObjCache when a view is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only compile unit tests on aura platforms Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/accessibility/ax_aura_obj_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/accessibility/ax_aura_obj_cache.h
diff --git a/ui/views/accessibility/ax_aura_obj_cache.h b/ui/views/accessibility/ax_aura_obj_cache.h
index a7bb50c99b42c67e8bc54da21f89fb9f2d3c14a4..1129c1d237a8dde51e796c9bcc57eb4f122db7be 100644
--- a/ui/views/accessibility/ax_aura_obj_cache.h
+++ b/ui/views/accessibility/ax_aura_obj_cache.h
@@ -38,9 +38,9 @@ class VIEWS_EXPORT AXAuraObjCache {
AXAuraObjWrapper* GetOrCreate(aura::Window* window);
// Gets an id given an Aura view.
- int32_t GetID(View* view);
- int32_t GetID(Widget* widget);
- int32_t GetID(aura::Window* window);
+ int32_t GetID(View* view) const;
+ int32_t GetID(Widget* widget) const;
+ int32_t GetID(aura::Window* window) const;
// Gets the next unique id for this cache. Useful for non-Aura view backed
// views.
@@ -78,8 +78,9 @@ class VIEWS_EXPORT AXAuraObjCache {
std::map<AuraView*, int32_t>& aura_view_to_id_map);
template <typename AuraView>
- int32_t GetIDInternal(AuraView* aura_view,
- std::map<AuraView*, int32_t>& aura_view_to_id_map);
+ int32_t GetIDInternal(
+ AuraView* aura_view,
+ const std::map<AuraView*, int32_t>& aura_view_to_id_map) const;
template <typename AuraView>
void RemoveInternal(AuraView* aura_view,
« no previous file with comments | « no previous file | ui/views/accessibility/ax_aura_obj_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698