Make docked panel always on top for Linux

Make docked panel always on top for Linux

This is caused by always_on_top_ is set to true in PanelGtk constructor and later on calling SetPanelAlwaysOnTop become no-op. The fix is to make the window always on top in PanelGtk::Initialize. 

BUG=245934
TEST=Manual test by launching a docked panel and checking if it is always on top
R=dimich@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203793

[Dmitry Titov, 2013-06-01 01:01:54]

https://codereview.chromium.org/16294002/diff/1/chrome/browser/ui/gtk/panels/...
File chrome/browser/ui/gtk/panels/panel_gtk.cc (right):

https://codereview.chromium.org/16294002/diff/1/chrome/browser/ui/gtk/panels/...
chrome/browser/ui/gtk/panels/panel_gtk.cc:212: always_on_top_(always_on_top),
How about you initialize this to 'false', and then call
SetPanelAlwaysOnTop(always_on_top) at the end of the c-tor? Then you don't need
Update...() function.

[jianli, 2013-06-01 02:47:03]

On 2013/06/01 01:01:54, Dmitry Titov wrote:
>
https://codereview.chromium.org/16294002/diff/1/chrome/browser/ui/gtk/panels/...
> File chrome/browser/ui/gtk/panels/panel_gtk.cc (right):
> 
>
https://codereview.chromium.org/16294002/diff/1/chrome/browser/ui/gtk/panels/...
> chrome/browser/ui/gtk/panels/panel_gtk.cc:212: always_on_top_(always_on_top),
> How about you initialize this to 'false', and then call
> SetPanelAlwaysOnTop(always_on_top) at the end of the c-tor? Then you don't
need
> Update...() function.

I can't do that because the gtk window has not been created yet.

[Dmitry Titov, 2013-06-03 17:47:14]

On 2013/06/01 02:47:03, jianli wrote:
> On 2013/06/01 01:01:54, Dmitry Titov wrote:
> >
>
https://codereview.chromium.org/16294002/diff/1/chrome/browser/ui/gtk/panels/...
> > File chrome/browser/ui/gtk/panels/panel_gtk.cc (right):
> > 
> >
>
https://codereview.chromium.org/16294002/diff/1/chrome/browser/ui/gtk/panels/...
> > chrome/browser/ui/gtk/panels/panel_gtk.cc:212:
always_on_top_(always_on_top),
> > How about you initialize this to 'false', and then call
> > SetPanelAlwaysOnTop(always_on_top) at the end of the c-tor? Then you don't
> need
> > Update...() function.
> 
> I can't do that because the gtk window has not been created yet.

You right, I was thinking about Init()... I don't think it's a good idea to add
UpdateFoo() kind of functions if we already have SetFoo(bool). We probably can
remove the check in the beginning of SetPanelAlwaysOnTop(bool) and always do
what parameter says. It seems we call this method only when panel is added to a
Collection, so it is probably ok to do.
If for some reason it is bad, I would add 'bool force' param to the
SetPanelAlwaysOnTop, at least this will be better documented then faceless
"Update" method w/o parameters...

[jianli, 2013-06-03 21:14:36]

Changed as suggested.

[Dmitry Titov, 2013-06-03 23:12:33]

lgtm, thanks!

[jianli, 2013-06-03 23:49:54]

Committed patchset #2 manually as r203793 (presubmit successful).