Make docked panel always on top for Linux

chrome/browser/ui/gtk/panels/panel_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/panels/panel_gtk.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkkeysyms.h>
 #include <X11/XF86keysym.h>
 
@@ skipping 191 matching lines @@
                                       const gfx::Rect& bounds,
                                       bool always_on_top) {
   PanelGtk* panel_gtk = new PanelGtk(panel, bounds, always_on_top);
   panel_gtk->Init();
   return panel_gtk;
 }
 
 PanelGtk::PanelGtk(Panel* panel, const gfx::Rect& bounds, bool always_on_top)
     : panel_(panel),
       bounds_(bounds),
       always_on_top_(always_on_top),

[Dmitry Titov, 2013/06/01 01:01:55]

How about you initialize this to 'false', and then call
SetPanelAlwaysOnTop(always_on_top) at the end of the c-tor? Then you don't need
Update...() function.

       is_shown_(false),
       paint_state_(PAINT_AS_INACTIVE),
       is_drawing_attention_(false),
       frame_cursor_(NULL),
       is_active_(!ui::ActiveWindowWatcherX::WMSupportsActivation()),
       is_minimized_(false),
       window_(NULL),
       window_container_(NULL),
       window_vbox_(NULL),
       render_area_event_box_(NULL),
@@ skipping 86 matching lines @@
   gtk_container_add(GTK_CONTAINER(render_area_event_box_),
                     contents_expanded_);
   gtk_widget_show(render_area_event_box_);
   gtk_box_pack_end(GTK_BOX(window_vbox_), render_area_event_box_,
                    TRUE, TRUE, 0);
 
   gtk_container_add(GTK_CONTAINER(window_), window_container_);
   gtk_widget_show(window_container_);
 
   ConnectAccelerators();
+
+  UpdateWindowAlwaysOnTopState();
 }
 
 void PanelGtk::SetWindowCornerStyle(panel::CornerStyle corner_style) {
   corner_style_ = corner_style;
   UpdateWindowShape();
 }
 
 void PanelGtk::MinimizePanelBySystem() {
   gtk_window_iconify(window_);
 }
@@ skipping 674 matching lines @@
 
 bool PanelGtk::IsPanelAlwaysOnTop() const {
   return always_on_top_;
 }
 
 void PanelGtk::SetPanelAlwaysOnTop(bool on_top) {
   if (always_on_top_ == on_top)
     return;
   always_on_top_ = on_top;
 
-  gtk_window_set_keep_above(window_, on_top);
+  UpdateWindowAlwaysOnTopState();
+}
+
+void PanelGtk::UpdateWindowAlwaysOnTopState() {
+  gtk_window_set_keep_above(window_, always_on_top_);
 
   // Do not show an icon in the task bar for always-on-top windows.
   // Window operations such as close, minimize etc. can only be done
   // from the panel UI.
-  gtk_window_set_skip_taskbar_hint(window_, on_top);
+  gtk_window_set_skip_taskbar_hint(window_, always_on_top_);
 
   // Show always-on-top windows on all the virtual desktops.
-  if (on_top)
+  if (always_on_top_)
     gtk_window_stick(window_);
   else
     gtk_window_unstick(window_);
 }
 
 void PanelGtk::EnableResizeByMouse(bool enable) {
 }
 
 void PanelGtk::UpdatePanelMinimizeRestoreButtonVisibility() {
   titlebar_->UpdateMinimizeRestoreButtonVisibility();
@@ skipping 152 matching lines @@
     default:
       NOTREACHED();
       return false;
   }
   return gtk_widget_get_visible(button->widget());
 }
 
 panel::CornerStyle GtkNativePanelTesting::GetWindowCornerStyle() const {
   return panel_gtk_->corner_style_;
 }