WebRTC: Enable OpenH264 for WebRTC standalone bots.

WebRTC: Enable OpenH264 for WebRTC standalone bots.

hbos@ in the WebRTC team is working on enabling OpenH264 as an H.264
encoder in Chrome as part of http://crbug.com/468365. This CL sets the
necessary GYP variables to turn it on in the build for standalone WebRTC
bots and the Chromium bots we control.

NOTICE: Due to licensing and patent reasons, OpenH264 cannot be enabled
by default for end-users. Going forward, the plan is that it will only be
enabled on WebRTC controlled bots and the Chromium official builders.

This is a reland of https://codereview.chromium.org/1577773002/ but with
iOS and Android excluded and with the variable updated to rtc_use_h264 instead.

BUG=576201
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298443

[phoglund_chromium, 2016-01-25 10:57:10]

phoglund@chromium.org changed reviewers:
+ hbos@chromium.org

[hbos_chromium, 2016-01-25 11:49:21]

Description was changed from

==========
WebRTC: Enable OpenH264 for WebRTC standalone bots.

hbos@ in the WebRTC team is working on enabling OpenH264 as an H.264
encoder in Chrome as part of http://crbug.com/468365. This CL sets the
necessary GYP variables to turn it on in the build for standalone WebRTC
bots and the Chromium bots we control.

NOTICE: Due to licensing and patent reasons, OpenH264 cannot be enabled
by default for end-users. Going forward, the plan is that it will only be
enabled on WebRTC controlled bots and the Chromium official builders.

This is a reland of https://codereview.chromium.org/1577773002/ but with
iOS excluded and with the variable updated to rtc_use_h264 instead.

BUG=576201
==========

to

==========
WebRTC: Enable OpenH264 for WebRTC standalone bots.

hbos@ in the WebRTC team is working on enabling OpenH264 as an H.264
encoder in Chrome as part of http://crbug.com/468365. This CL sets the
necessary GYP variables to turn it on in the build for standalone WebRTC
bots and the Chromium bots we control.

NOTICE: Due to licensing and patent reasons, OpenH264 cannot be enabled
by default for end-users. Going forward, the plan is that it will only be
enabled on WebRTC controlled bots and the Chromium official builders.

This is a reland of https://codereview.chromium.org/1577773002/ but with
iOS and Android excluded and with the variable updated to rtc_use_h264 instead.

BUG=576201
==========

[hbos_chromium, 2016-01-25 11:54:37]

This change is not just for GN, right?

What is scripts/slave/recipe_modules/chromium/config.py? Thinking about how it
was updated in the original CL (that was reverted and before we changed the name
of the flag and made it conditional on OS):
https://codereview.chromium.org/1577773002/diff/20001/scripts/slave/recipe_mo....

[phoglund_chromium, 2016-01-25 12:04:02]

On 2016/01/25 11:54:37, hbos_chromium wrote:
> This change is not just for GN, right?
> 

No, as you can see it changes for instance 
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json,
which isn't a GN bot.

> What is scripts/slave/recipe_modules/chromium/config.py? Thinking about how it
> was updated in the original CL (that was reverted and before we changed the
name
> of the flag and made it conditional on OS):
>
https://codereview.chromium.org/1577773002/diff/20001/scripts/slave/recipe_mo....

Do you mean _where_ is chromium/config.py? I don't know, it wasn't in Henrik's
reland patch, only webrtc/chromium_config.py was there. I don't know if this
is a mistake. You know better than me I reckon.

[phoglund_chromium, 2016-01-25 12:18:52]

phoglund@chromium.org changed reviewers:
+ kjellander@chromium.org

[phoglund_chromium, 2016-01-25 12:20:21]

I honestly don't understand what Henrik was trying to do with this change:
https://codereview.chromium.org/1577773002/diff/20001/scripts/slave/recipe_mo...,
but I think it doesn't have any effect. At least, not yet. The set of changed
.json files seems the same, and as far I can tell those changes are correct
(i.e. all WebRTC standalone builders start passing branding, use_openh264 etc,
both for gyp and GN builders).

[hbos_chromium, 2016-01-25 13:57:50]

lgtm

[hbos_chromium, 2016-01-25 14:00:15]

https://codereview.chromium.org/1629353002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/chromium_config.py (right):

https://codereview.chromium.org/1629353002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/chromium_config.py:59:
@CONFIG_CTX(includes=['webrtc_gn'])
Wait, was this change on purpose? Looks unrelated to what we're doing.

[phoglund_chromium, 2016-01-25 14:07:24]

phoglund@chromium.org changed reviewers:
+ phajdan.jr@chromium.org
- kjellander@chromium.org

[phoglund_chromium, 2016-01-25 14:07:24]

phajdan: please review for infra. I'm shepherding this CL while kjellander@ is
on vacation.

[phoglund_chromium, 2016-01-27 09:19:27]

phoglund@chromium.org changed reviewers:
+ tandrii@chromium.org
- phajdan.jr@chromium.org

[phoglund_chromium, 2016-01-27 09:19:27]

No response from phajdan. tandrii@, would you mind reviewing this for infra?
It's a reland of kjellander@'s h264 patch with some minor changes (as you can
see in the patch sets).

[tandrii(chromium), 2016-01-27 11:50:26]

lgtm % a comment on hbos comment would be nice. Specifically, why did it work
before you've changed gn => webrtc_gn, or maybe it didn't?

[phoglund_chromium, 2016-01-28 10:50:14]

https://codereview.chromium.org/1629353002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/chromium_config.py (right):

https://codereview.chromium.org/1629353002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/chromium_config.py:59:
@CONFIG_CTX(includes=['webrtc_gn'])
On 2016/01/25 14:00:15, hbos_chromium wrote:
> Wait, was this change on purpose? Looks unrelated to what we're doing.

Yeah, I better get rid of these changes, it looks like something was rebased in.
I think they make no functional difference, it's just that we include a superset
of gn and extend the gn args rather than overwrite them.

[phoglund_chromium, 2016-01-28 10:54:57]

I think I've figured everything out; rebasing + submitting

https://codereview.chromium.org/1629353002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/chromium_config.py (right):

https://codereview.chromium.org/1629353002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/chromium_config.py:59:
@CONFIG_CTX(includes=['webrtc_gn'])
On 2016/01/28 10:50:13, phoglund_chrome wrote:
> On 2016/01/25 14:00:15, hbos_chromium wrote:
> > Wait, was this change on purpose? Looks unrelated to what we're doing.
> 
> Yeah, I better get rid of these changes, it looks like something was rebased
in.
> I think they make no functional difference, it's just that we include a
superset
> of gn and extend the gn args rather than overwrite them.

Aha, never mind. The purpose of this change is to use webrtc_gn defined on line
51, which adds the parameters we need. Reverting back to the old changes means
we lose the h264 parameters on the fuzzer bot, and we want those there.

[tandrii(chromium), 2016-01-28 10:55:35]

lgtm

[phoglund_chromium, 2016-01-28 11:40:39]

The CQ bit was checked by phoglund@chromium.org

[phoglund_chromium, 2016-01-28 11:40:40]

The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org,
tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1629353002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-28 11:40:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1629353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1629353002/40001

[commit-bot: I haz the power, 2016-01-28 11:44:00]

Description was changed from

==========
WebRTC: Enable OpenH264 for WebRTC standalone bots.

hbos@ in the WebRTC team is working on enabling OpenH264 as an H.264
encoder in Chrome as part of http://crbug.com/468365. This CL sets the
necessary GYP variables to turn it on in the build for standalone WebRTC
bots and the Chromium bots we control.

NOTICE: Due to licensing and patent reasons, OpenH264 cannot be enabled
by default for end-users. Going forward, the plan is that it will only be
enabled on WebRTC controlled bots and the Chromium official builders.

This is a reland of https://codereview.chromium.org/1577773002/ but with
iOS and Android excluded and with the variable updated to rtc_use_h264 instead.

BUG=576201
==========

to

==========
WebRTC: Enable OpenH264 for WebRTC standalone bots.

hbos@ in the WebRTC team is working on enabling OpenH264 as an H.264
encoder in Chrome as part of http://crbug.com/468365. This CL sets the
necessary GYP variables to turn it on in the build for standalone WebRTC
bots and the Chromium bots we control.

NOTICE: Due to licensing and patent reasons, OpenH264 cannot be enabled
by default for end-users. Going forward, the plan is that it will only be
enabled on WebRTC controlled bots and the Chromium official builders.

This is a reland of https://codereview.chromium.org/1577773002/ but with
iOS and Android excluded and with the variable updated to rtc_use_h264 instead.

BUG=576201

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298443
==========

[commit-bot: I haz the power, 2016-01-28 11:44:01]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298443