WebRTC: Enable OpenH264 for WebRTC standalone bots.

scripts/slave/recipe_modules/chromium/config.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import pipes
 
 from recipe_engine.config import config_item_context, ConfigGroup
 from recipe_engine.config import Dict, List, Single, Static, Set, BadConf
 from recipe_engine.config_types import Path
 
@@ skipping 348 matching lines @@
 @config_ctx()
 def ffmpeg_branding(c, branding=None):
   if branding:
     c.gyp_env.GYP_DEFINES['ffmpeg_branding'] = branding
 
 @config_ctx()
 def proprietary_codecs(c, invert=False):
   c.gyp_env.GYP_DEFINES['proprietary_codecs'] = int(not invert)
 
 @config_ctx()
+def openh264(c):

[hbos_chromium, 2016/01/11 14:21:09]

Hmm the name "openh264" might be misleading here since this h264 feature relies
on both openh264 and ffmpeg. That's why I refer to it as "third_party_h264"
(perhaps not the best name either) since it relies on multiple third_party
libraries.

(I didn't simply call it webrtc_h264 because there is an iOS enc/dec too with
video toolbox. And HW versions as well for android. And plans for more. Ugh.)

[kjellander_chromium, 2016/01/12 10:11:45]

Well, OpenH264 is not used at all in Chromium, as the ffmpeg version implements
its own H264 decoder.
That makes me think this name is better than third_party_h264. Possibly
third_party_openh264 could be an option, but since there's no other openh264
anywhere, I think the third_party prefix doesn't add anything useful.
The naming of these configs also aren't that important, since they're only
referenced by the buildbot configurations.

+  ffmpeg_branding(c, branding='Chrome')

[hbos_chromium, 2016/01/11 14:21:09]

(Any idea what happens if multiple defs are used and ffmpeg_branding is
accidentally set multiple times? Just wondering since I see ffmpeg_branding in
other places in this file.)

[kjellander_chromium, 2016/01/12 10:11:45]

Any latter will overwrite the previous, but it's unlikely to happen since there
aren't that long chains that uses this setting. The resulting GYP_DEFINES will
also show up in the JSON files for the different bot configurations, allowing
reviewers to spot such an error.

+  c.gyp_env.GYP_DEFINES['use_openh264'] = 1
+  c.gyp_env.GYP_DEFINES['use_third_party_h264'] = 1
+
+@config_ctx()
 def chrome_with_codecs(c):
   ffmpeg_branding(c, branding='Chrome')
   proprietary_codecs(c)
 
 @config_ctx()
 def chromiumos(c):
   c.gyp_env.GYP_DEFINES['chromeos'] = 1
 
 @config_ctx(includes=['chromiumos'])
 def chromeos(c):
@@ skipping 441 matching lines @@
 def chromium_deterministic_build(c):
   c.gyp_env.GYP_DEFINES['dont_embed_build_metadata'] = 1
 
 @config_ctx(includes=['chromium_clang'])
 def cast_linux(c):
   c.gyp_env.GYP_DEFINES['chromecast'] = 1
 
 @config_ctx()
 def internal_gles2_conform_tests(c):
   c.gyp_env.GYP_DEFINES['internal_gles2_conform_tests'] = 1