Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Issue 162913002: Use _NEWLIB_VERSION macro to detect newlib. (Closed)

Created:
6 years, 10 months ago by Sam Clegg
Modified:
6 years, 10 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Use _NEWLIB_VERSION macro to detect newlib. This is clearer than using !__GLIBC__ R=bradnelson@google.com Committed: https://code.google.com/p/naclports/source/detail?r=1102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M ports/civetweb/nacl.patch View 2 chunks +16 lines, -16 lines 0 comments Download
M ports/dosbox/nacl.patch View 1 chunk +1 line, -1 line 0 comments Download
M ports/leveldb/nacl.patch View 1 chunk +1 line, -1 line 0 comments Download
M ports/libtar/nacl.patch View 1 chunk +1 line, -1 line 0 comments Download
M ports/netcat/nacl.patch View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
6 years, 10 months ago (2014-02-13 06:53:15 UTC) #1
bradn
lgtm
6 years, 10 months ago (2014-02-13 18:53:55 UTC) #2
Sam Clegg
6 years, 10 months ago (2014-02-13 19:13:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698