Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1628513002: Add proper null checks to android's find in page UI behavior. (Closed)

Created:
4 years, 11 months ago by Ted C
Modified:
4 years, 11 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add proper null checks to android's find in page UI behavior. Pending events in android can occur after the native find in page has been destroyed, so ensure the bridge is non null before trying to act on it. This adds asserts to places where the bridge is not allowed to be null either. BUG=489253 Committed: https://crrev.com/75a8a3fb3fadade6287cf19325419da72de0b99d Cr-Commit-Position: refs/heads/master@{#371056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java View 7 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
4 years, 11 months ago (2016-01-22 21:01:13 UTC) #2
Theresa
lgtm
4 years, 11 months ago (2016-01-22 21:14:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1628513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1628513002/1
4 years, 11 months ago (2016-01-22 21:17:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 22:18:30 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 22:19:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75a8a3fb3fadade6287cf19325419da72de0b99d
Cr-Commit-Position: refs/heads/master@{#371056}

Powered by Google App Engine
This is Rietveld 408576698