chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java - Issue 1628513002: Add proper null checks to android's find in page UI behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java

Issue 1628513002: Add proper null checks to android's find in page UI behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java

index 1935eaeaf026cea2703f3ec9d1436acd8026be03..ea345e51db2be7676670f47083f8871e36a667e6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java

@@ -144,6 +144,7 @@ class FindResultBar extends View {

/** Dismisses this results bar by removing it from the view hierarchy. */

public void dismiss() {

mDismissing = true;

+ mFindInPageBridge = null;

if (mVisibilityAnimation != null && mVisibilityAnimation.isRunning()) {

mVisibilityAnimation.cancel();

}

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java » ('j') | no next file with comments »