posinset and setsize for input type, radio, exposed in AX tree

third_party/WebKit/Source/core/html/HTMLInputElement.h

Index: third_party/WebKit/Source/core/html/HTMLInputElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.h b/third_party/WebKit/Source/core/html/HTMLInputElement.h
index b0560ed4fb65c069646751b8bda6090eb5621d40..5137cc7c26213ad046a18618433a11b082d04df9 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.h
@@ -95,6 +95,8 @@ public:
 
     bool isImage() const;
 
+    bool isRadioButton() const;

[tkent, 2016/03/01 01:43:00]

Please do not add this.
Use |input->formControlType() == InputTypeNames::radio| outside
HTMLInputElement.

[tkent, 2016/03/01 02:17:49]

oops, formControlType() -> type()

[je_julie(Not used), 2016/03/01 13:46:07]

tkent and keishi,
keishi left comment
"third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:324: if
(isHTMLInputElement(node()) && toHTMLInputElement(*node()).type() ==
InputTypeNames::radio)
We try to avoid the "if (input.type==foo) input.bar()" pattern using the
InputType class."at #16 review comment and I chose the way to add that API.
I'd better checking radio type with type() API at this patch for now?
WDYT?

[tkent, 2016/03/02 00:40:02]

Please follow my comment.


Keishi's comment meant we should have done:
  if (isHTMLInputElement(node()))
     toHTMLInputElement(*node()).needUpdatePositionOfRadioGroup();
and should have applied virtual dispatch by InputType if necessary.

In the latest Patch Set:

if (isHTMLInputElement(node) && toHTMLInputElement(node)->isRadioButton())
    return AXRadioInput::create(layoutObject, *this);

Our normal way is to introduce HTMLInputElement::createAXObject(), and
InputType::createAXObject.  However HTMLInputElement should not have knowledge
of AX objects in modules/accessibility/.  So type checking by type() is
reasonable.

Introducing isRadioButton() improves nothing.

+
     bool checked() const;
     void setChecked(bool, TextFieldEventBehavior = DispatchNoEvent);
     void dispatchChangeEventIfNeeded();
@@ -267,6 +269,8 @@ public:
     bool isPlaceholderVisible() const override { return m_isPlaceholderVisible; }
     void setPlaceholderVisibility(bool) override;
 
+    unsigned sizeOfRadioGroup() const;
+
 protected:
     HTMLInputElement(Document&, HTMLFormElement*, bool createdByParser);