posinset and setsize for input type, radio, exposed in AX tree

third_party/WebKit/Source/core/html/HTMLInputElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 77 matching lines @@
     bool isSteppable() const;
 
     // Returns true if the type is button, reset, or submit.
     bool isTextButton() const;
     // Returns true if the type is email, number, password, search, tel, text,
     // or url.
     bool isTextField() const;
 
     bool isImage() const;
 
+    bool isRadioButton() const;

[tkent, 2016/03/01 01:43:00]

Please do not add this.
Use |input->formControlType() == InputTypeNames::radio| outside
HTMLInputElement.

[tkent, 2016/03/01 02:17:49]

oops, formControlType() -> type()

[je_julie(Not used), 2016/03/01 13:46:07]

tkent and keishi,
keishi left comment
"third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:324: if
(isHTMLInputElement(node()) && toHTMLInputElement(*node()).type() ==
InputTypeNames::radio)
We try to avoid the "if (input.type==foo) input.bar()" pattern using the
InputType class."at #16 review comment and I chose the way to add that API.
I'd better checking radio type with type() API at this patch for now?
WDYT?

[tkent, 2016/03/02 00:40:02]

Please follow my comment.


Keishi's comment meant we should have done:
  if (isHTMLInputElement(node()))
     toHTMLInputElement(*node()).needUpdatePositionOfRadioGroup();
and should have applied virtual dispatch by InputType if necessary.

In the latest Patch Set:

if (isHTMLInputElement(node) && toHTMLInputElement(node)->isRadioButton())
    return AXRadioInput::create(layoutObject, *this);

Our normal way is to introduce HTMLInputElement::createAXObject(), and
InputType::createAXObject.  However HTMLInputElement should not have knowledge
of AX objects in modules/accessibility/.  So type checking by type() is
reasonable.

Introducing isRadioButton() improves nothing.

+
     bool checked() const;
     void setChecked(bool, TextFieldEventBehavior = DispatchNoEvent);
     void dispatchChangeEventIfNeeded();
 
     // 'indeterminate' is a state independent of the checked state that causes the control to draw in a way that hides the actual state.
     bool indeterminate() const { return m_isIndeterminate; }
     void setIndeterminate(bool);
     // shouldAppearChecked is used by the layout tree/CSS while checked() is used by JS to determine checked state
     bool shouldAppearChecked() const;
     bool shouldAppearIndeterminate() const override;
@@ skipping 152 matching lines @@
     AXObject* popupRootAXObject();
     void didNotifySubtreeInsertionsToDocument() override;
 
     virtual void ensureFallbackContent();
     virtual void ensurePrimaryContent();
     bool hasFallbackContent() const;
 
     bool isPlaceholderVisible() const override { return m_isPlaceholderVisible; }
     void setPlaceholderVisibility(bool) override;
 
+    unsigned sizeOfRadioGroup() const;
+
 protected:
     HTMLInputElement(Document&, HTMLFormElement*, bool createdByParser);
 
     void defaultEventHandler(Event*) override;
 
 private:
     enum AutoCompleteSetting { Uninitialized, On, Off };
 
     void didAddUserAgentShadowRoot(ShadowRoot&) final;
     void willAddFirstAuthorShadowRoot() final;
@@ skipping 117 matching lines @@
     // The ImageLoader must be owned by this element because the loader code assumes
     // that it lives as long as its owning element lives. If we move the loader into
     // the ImageInput object we may delete the loader while this element lives on.
     OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader;
     OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserver;
 };
 
 } // namespace blink
 
 #endif // HTMLInputElement_h