Revert 204354 "Add read support to PNaClTranslationCache"

Revert 204354 "Add read support to PNaClTranslationCache"

> Add read support to PNaClTranslationCache
> 
> Uses most of the same logic from PNaClTranslationCacheWriteEntry (now renamed PNaClTranslationCacheEntry). There is a little ugliness because of the asymmetry in the string type (const ref for write vs pointer for read) but I'm not 100% sure yet that it will stay as strings.
> R=jvoung@chromium.org
> BUG= https://code.google.com/p/nativeclient/issues/detail?id=3372
> 
> Review URL: https://chromiumcodereview.appspot.com/15647018

TBR=dschuff@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204382

[Lei Zhang, 2013-06-06 02:19:16]

Committed patchset #1 manually as r204382.

[Lei Zhang, 2013-06-06 02:20:39]

Failed 2x in a row on WinXP.
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds...
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds...

[ RUN      ] PNaClTranslationCacheTest.GetLargeOnDisk
[4084:2700:0605/191325:1604125:ERROR:pnacl_translation_cache.cc(254)] Failed to
complete write to PNaCl Translation Cache Entry: -402
browser\nacl_host\pnacl_translation_cache_unittest.cc(69): error: Value of:
store_cb.GetResult(net::ERR_IO_PENDING)
  Actual: -402
Expected: net::OK
Which is: 0
browser\nacl_host\pnacl_translation_cache_unittest.cc(129): error: Value of:
cache_->Size()
  Actual: 0
Expected: 1
browser\nacl_host\pnacl_translation_cache_unittest.cc(76): error: Value of:
load_cb.GetResult(net::ERR_IO_PENDING)
  Actual: -2
Expected: net::OK
Which is: 0
browser\nacl_host\pnacl_translation_cache_unittest.cc(130): error: Value of:
GetNexe(test_key).compare(large_buffer)
  Actual: -1
Expected: 0
[  FAILED  ] PNaClTranslationCacheTest.GetLargeOnDisk (703 ms)

[ RUN      ] PNaClTranslationCacheTest.StoreLargeOnDisk
[2328:3956:0605/191557:1755718:ERROR:pnacl_translation_cache.cc(254)] Failed to
complete write to PNaCl Translation Cache Entry: -402
browser\nacl_host\pnacl_translation_cache_unittest.cc(69): error: Value of:
store_cb.GetResult(net::ERR_IO_PENDING)
  Actual: -402
Expected: net::OK
Which is: 0
browser\nacl_host\pnacl_translation_cache_unittest.cc(105): error: Value of:
cache_->Size()
  Actual: 0
Expected: 1
[  FAILED  ] PNaClTranslationCacheTest.StoreLargeOnDisk (547 ms)

Failed on Dr. Memory:

http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Tests%20%2...

[----------] 9 tests from PNaClTranslationCacheTest
[ RUN      ] PNaClTranslationCacheTest.StoreSmallInMem
[       OK ] PNaClTranslationCacheTest.StoreSmallInMem (62 ms)
[ RUN      ] PNaClTranslationCacheTest.StoreSmallOnDisk
[       OK ] PNaClTranslationCacheTest.StoreSmallOnDisk (530 ms)
[ RUN      ] PNaClTranslationCacheTest.StoreLargeOnDisk
~~Dr.M~~ 
~~Dr.M~~ Error #1: WARNING: heap allocation failed
~~Dr.M~~ # 0 MSVCR100D.dll!operator new                                         
      +0x11     (0x6c967db1 <MSVCR100D.dll+0x107db1>)
~~Dr.M~~ # 1 net.dll!std::_Allocate<char>                                       
      +0x2a     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xmemory:36] (0x6ba5e8fb <net.dll+0x4e8fb>)
~~Dr.M~~ # 2 net.dll!std::allocator<char>::allocate                             
      +0x11     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xmemory:187] (0x6ba5e822 <net.dll+0x4e822>)
~~Dr.M~~ # 3
net.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char>
>::_Copy+0xb7     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xstring:1932] (0x6ba5e688 <net.dll+0x4e688>)
~~Dr.M~~ # 4
net.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char>
>::_Grow+0x3b     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xstring:1962] (0x6ba5e38c <net.dll+0x4e38c>)
~~Dr.M~~ # 5
net.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char>
>::assign+0x74     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xstring:901] (0x6ba5e0f5 <net.dll+0x4e0f5>)
~~Dr.M~~ # 6
net.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char>
>::basic_string<char,std::char_traits<char>,std::allocator<char> >+0x69    
[c:\program files (x86)\microsoft visual studio 10.0\vc\include\xstring:545]
(0x6ba5d99a <net.dll+0x4d99a>)
~~Dr.M~~ # 7 net.dll!net::StringIOBuffer::StringIOBuffer                        
      +0x5f     [net\base\io_buffer.cc:44] (0x6be98340 <net.dll+0x488340>)
~~Dr.M~~ # 8 pnacl_cache::PNaClTranslationCacheEntry::WriteEntry                
      +0x85     [chrome\browser\nacl_host\pnacl_translation_cache.cc:162]
(0x031764d6 <unit_tests.exe+0x26e64d6>)
~~Dr.M~~ # 9 pnacl_cache::PNaClTranslationCacheEntry::DispatchNext              
      +0x2e3    [chrome\browser\nacl_host\pnacl_translation_cache.cc:243]
(0x03176d34 <unit_tests.exe+0x26e6d34>)
~~Dr.M~~ #10 base::internal::RunnableAdapter<void (__thiscall
pnacl_cache::PNaClTranslationCacheEntry::*)(int)>::Run+0x1f    
[base\bind_internal.h:190] (0x0317aed0 <unit_tests.exe+0x26eaed0>)
~~Dr.M~~ Note: @0:09:57.581 in thread 6756
~~Dr.M~~ 
~~Dr.M~~ Error #2: WARNING: heap allocation failed
~~Dr.M~~ # 0 MSVCR100D.dll!operator new                                         
      +0x11     (0x6c967db1 <MSVCR100D.dll+0x107db1>)
~~Dr.M~~ # 1 net.dll!std::_Allocate<char>                                       
      +0x2a     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xmemory:36] (0x6ba5e8fb <net.dll+0x4e8fb>)
~~Dr.M~~ # 2 net.dll!std::allocator<char>::allocate                             
      +0x11     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xmemory:187] (0x6ba5e822 <net.dll+0x4e822>)
~~Dr.M~~ # 3
net.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char>
>::_Copy+0xe1     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xstring:1936] (0x6ba5e6b2 <net.dll+0x4e6b2>)
~~Dr.M~~ # 4
net.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char>
>::_Grow+0x3b     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xstring:1962] (0x6ba5e38c <net.dll+0x4e38c>)
~~Dr.M~~ # 5
net.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char>
>::assign+0x74     [c:\program files (x86)\microsoft visual studio
10.0\vc\include\xstring:901] (0x6ba5e0f5 <net.dll+0x4e0f5>)
~~Dr.M~~ # 6
net.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char>
>::basic_string<char,std::char_traits<char>,std::allocator<char> >+0x69    
[c:\program files (x86)\microsoft visual studio 10.0\vc\include\xstring:545]
(0x6ba5d99a <net.dll+0x4d99a>)
~~Dr.M~~ # 7 net.dll!net::StringIOBuffer::StringIOBuffer                        
      +0x5f     [net\base\io_buffer.cc:44] (0x6be98340 <net.dll+0x488340>)
~~Dr.M~~ # 8 pnacl_cache::PNaClTranslationCacheEntry::WriteEntry                
      +0x85     [chrome\browser\nacl_host\pnacl_translation_cache.cc:162]
(0x031764d6 <unit_tests.exe+0x26e64d6>)
~~Dr.M~~ # 9 pnacl_cache::PNaClTranslationCacheEntry::DispatchNext              
      +0x2e3    [chrome\browser\nacl_host\pnacl_translation_cache.cc:243]
(0x03176d34 <unit_tests.exe+0x26e6d34>)
~~Dr.M~~ #10 base::internal::RunnableAdapter<void (__thiscall
pnacl_cache::PNaClTranslationCacheEntry::*)(int)>::Run+0x1f    
[base\bind_internal.h:190] (0x0317aed0 <unit_tests.exe+0x26eaed0>)
~~Dr.M~~ Note: @0:09:57.581 in thread 6756
Backtrace:

[Lei Zhang, 2013-06-06 02:21:18]

codereview overescapes links, FYI - sed 's/%25/%/g'