Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: trunk/src/chrome/browser/nacl_host/pnacl_translation_cache.h

Issue 16279009: Revert 204354 "Add read support to PNaClTranslationCache" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/browser/nacl_host/pnacl_translation_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/nacl_host/pnacl_translation_cache.h
===================================================================
--- trunk/src/chrome/browser/nacl_host/pnacl_translation_cache.h (revision 204381)
+++ trunk/src/chrome/browser/nacl_host/pnacl_translation_cache.h (working copy)
@@ -22,7 +22,7 @@
namespace pnacl_cache {
typedef base::Callback<void(int)> CompletionCallback;
-class PNaClTranslationCacheEntry;
+class PNaClTranslationCacheWriteEntry;
extern const int kMaxMemCacheSize;
class PNaClTranslationCache
@@ -48,20 +48,19 @@
const std::string& nexe,
const CompletionCallback& callback);
- // Retrieve the nexe from the translation cache. Write the data into |nexe|
- // and call |callback| with the result (0 on success and <0 otherwise)
- void GetNexe(const std::string& key,
- std::string* nexe,
- const CompletionCallback& callback);
+ // Retrieve the nexe from the translation cache. (Not implemented yet.)
+ int GetNexe(const std::string& key,
+ std::string* nexe,
+ const CompletionCallback& callback);
// Return the number of entries in the cache backend.
int Size();
private:
- friend class PNaClTranslationCacheEntry;
- // PNaClTranslationCacheEntry should only use the
- // OpComplete and backend methods on PNaClTranslationCache.
- void OpComplete(PNaClTranslationCacheEntry* entry);
+ friend class PNaClTranslationCacheWriteEntry;
+ // PNaClTranslationCacheWriteEntry should only use the
+ // WriteComplete and backend methods on PNaClTranslationCache.
+ void WriteComplete(PNaClTranslationCacheWriteEntry* entry);
disk_cache::Backend* backend() { return disk_cache_; }
int InitWithDiskBackend(const base::FilePath& disk_cache_dir,
@@ -80,7 +79,8 @@
disk_cache::Backend* disk_cache_;
CompletionCallback init_callback_;
bool in_memory_;
- std::map<void*, scoped_refptr<PNaClTranslationCacheEntry> > open_entries_;
+ std::map<void*, scoped_refptr<PNaClTranslationCacheWriteEntry> >
+ write_entries_;
DISALLOW_COPY_AND_ASSIGN(PNaClTranslationCache);
};
« no previous file with comments | « no previous file | trunk/src/chrome/browser/nacl_host/pnacl_translation_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698