[Chromecast] Depend on Chromium's freetype-android

build/linux/BUILD.gn

Index: build/linux/BUILD.gn
diff --git a/build/linux/BUILD.gn b/build/linux/BUILD.gn
index 6a1939dd15b933f40123dd6992facfddc3ccb976..8665294324d5b363ecd170f1fe41a7c05bccde0f 100644
--- a/build/linux/BUILD.gn
+++ b/build/linux/BUILD.gn
@@ -12,6 +12,7 @@ gypi_values = exec_script("//build/gypi_to_gn.py",
                           [ "system.gyp" ])
 
 use_system_fontconfig = !is_chromecast

[slan, 2016/01/25 17:35:16]

Could you add a comment above these two vars explaining that Chromecast builds
cannot rely on system libraries for this functionality?

[bcf, 2016/01/25 19:51:33]

Done.

In addition, I just changed freetype2 to check for chromecast directly, because
probably only chromecast wants to use freetype-android

[slan, 2016/01/27 23:57:06]

Though I understand that directly checking for Chromecast is fewer lines, I
think we should value consistency here. I would prefer we use the same
convention as is used with fontconfig.

+use_system_freetype = !is_chromecast
 
 # If brlapi isn't needed, don't require it to be installed.
 if (use_brlapi) {
@@ -115,3 +116,13 @@ group("fontconfig") {
     ]
   }
 }
+
+group("freetype2") {
+  if (use_system_freetype) {
+    public_configs = [ "//build/config/linux:freetype2" ]
+  } else {
+    public_deps = [
+      "//third_party/freetype2",

[slan, 2016/01/25 17:35:16]

This should be freetype-android target.

Also, there should be some kind of assert in here or a comment that explains
what's happening. Even with (some) context on the issue, this is confusing. Is
there a bug that we can link to to provide more context?

[bcf, 2016/01/25 19:51:33]

I haven't update GN yet in PS1. Its done now though.

I also added a comment for this.

+    ]
+  }
+}