[Chromecast] Depend on Chromium's freetype-android

build/linux/BUILD.gn

 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/linux/pkg_config.gni")
 import("//tools/generate_library_loader/generate_library_loader.gni")
 
 gypi_values = exec_script("//build/gypi_to_gn.py",
                           [ rebase_path("system.gyp") ],
                           "scope",
                           [ "system.gyp" ])
 
 use_system_fontconfig = !is_chromecast

[slan, 2016/01/25 17:35:16]

Could you add a comment above these two vars explaining that Chromecast builds
cannot rely on system libraries for this functionality?

[bcf, 2016/01/25 19:51:33]

Done.

In addition, I just changed freetype2 to check for chromecast directly, because
probably only chromecast wants to use freetype-android

[slan, 2016/01/27 23:57:06]

Though I understand that directly checking for Chromecast is fewer lines, I
think we should value consistency here. I would prefer we use the same
convention as is used with fontconfig.

+use_system_freetype = !is_chromecast
 
 # If brlapi isn't needed, don't require it to be installed.
 if (use_brlapi) {
   config("brlapi_config") {
     defines = [ "USE_BRLAPI" ]
   }
 
   # TODO(GYP) linux_link_brlapi support. Is this needed?
   generate_library_loader("libbrlapi") {
     name = "LibBrlapiLoader"
@@ skipping 83 matching lines @@
 
 group("fontconfig") {
   if (use_system_fontconfig) {
     public_configs = [ "//build/config/linux:fontconfig" ]
   } else {
     public_deps = [
       "//third_party/fontconfig",
     ]
   }
 }
+
+group("freetype2") {
+  if (use_system_freetype) {
+    public_configs = [ "//build/config/linux:freetype2" ]
+  } else {
+    public_deps = [
+      "//third_party/freetype2",

[slan, 2016/01/25 17:35:16]

This should be freetype-android target.

Also, there should be some kind of assert in here or a comment that explains
what's happening. Even with (some) context on the issue, this is confusing. Is
there a bug that we can link to to provide more context?

[bcf, 2016/01/25 19:51:33]

I haven't update GN yet in PS1. Its done now though.

I also added a comment for this.

+    ]
+  }
+}