[Chromecast] Depend on Chromium's freetype-android

content/shell/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/ui.gni")
 import("//build/config/win/manifest.gni")
 import("//tools/grit/repack.gni")
 import("//tools/grit/grit_rule.gni")
@@ skipping 295 matching lines @@
     #deps -= [ 'copy_test_netscape_plugin' ]  TODO(GYP)
   }
 
   if (is_chromeos) {
     deps += [
       "//chromeos",
       "//ui/wm:test_support",
     ]
   }
 
-  if (is_linux && !is_chromecast) {
+  if (is_linux) {
     deps += [ "//third_party/freetype2" ]

[Dirk Pranke, 2016/01/28 01:09:21]

is this right? you'll get //third_party/freetype2 in content_shell even for
chromecast, rather than //third_party/freetype-android ?

(just checking that that's the intent)

[bcf, 2016/01/28 21:37:28]

This logic is from this CL: https://codereview.chromium.org/1192933002

It seems like the issue from that CL no longer exists with statically linked
freetype

[Nico, 2016/01/28 21:55:47]

This looks wrong to me too -- you probably don't want to depend on different
freetypes? Don't you want build/linux/freetype here as dep (and everywhere else
too)?

[bcf, 2016/01/28 22:31:04]

We discussed in the predecessor of this CL that third_party/freetype2 is only
for testing. (See third_party/freetype2/README.chromium). content_shell_lib
should always use third_party/freetype2 to ensure fonts always render the same
way for tests. 

[Nico, 2016/01/28 22:33:01]

Does android use freetype2 for tests and freetype-android for production too?
Seems weird to test with one freetype and ship another, no?

   }
 
   if (!enable_plugins) {
     sources -= [
       "browser/shell_plugin_service_filter.cc",
       "browser/shell_plugin_service_filter.h",
     ]
   }
 }
 
@@ skipping 157 matching lines @@
     sources = [
       "app/shell_content_main.cc",
       "app/shell_content_main.h",
     ]
 
     deps = [
       ":content_shell_lib",
     ]
   }
 }