Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1192933002: Remove dependency of libfreetype.so.6 in chromecast test build (Closed)

Created:
5 years, 6 months ago by yucliu1
Modified:
5 years, 6 months ago
Reviewers:
cjhopman, gunsch
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency of libfreetype.so.6 in chromecast test build cast_shell_browser_test requires content_shell_lib. Set use_custom_freetype to 0 to use system's freetype library when building test image on arm. libfreetype.so.6 is required by layout test on linux. Since we don't run layout test on arm, it's safe to remove it. Committed: https://crrev.com/efaa2e77a7ffa637ce6ae7aadc3e67388c79d66a Cr-Commit-Position: refs/heads/master@{#335846}

Patch Set 1 #

Total comments: 1

Patch Set 2 : no OS guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
yucliu1
5 years, 6 months ago (2015-06-19 18:03:04 UTC) #2
gunsch
Couple other notes: 1) You'll need a build/ OWNER to approve this CL 2) For ...
5 years, 6 months ago (2015-06-19 23:32:46 UTC) #3
yucliu1
On 2015/06/19 23:32:46, gunsch wrote: > Couple other notes: > 1) You'll need a build/ ...
5 years, 6 months ago (2015-06-20 00:32:29 UTC) #4
gunsch
https://code.google.com/p/chromium/codesearch#chromium/src/build/OWNERS&q=src/build/owners&sq=package:chromium&l=1 or just run "git cl owners" locally
5 years, 6 months ago (2015-06-20 00:35:29 UTC) #5
yucliu1
Add build/ OWNER Remove OS=="linux" guard
5 years, 6 months ago (2015-06-22 00:09:53 UTC) #7
gunsch
lgtm for chromecast
5 years, 6 months ago (2015-06-22 16:43:04 UTC) #8
cjhopman
lgtm
5 years, 6 months ago (2015-06-23 20:49:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192933002/20001
5 years, 6 months ago (2015-06-23 23:54:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 01:35:29 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 01:36:34 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/efaa2e77a7ffa637ce6ae7aadc3e67388c79d66a
Cr-Commit-Position: refs/heads/master@{#335846}

Powered by Google App Engine
This is Rietveld 408576698