Issue 1627024: Add ExtensionFunctionDispatcher::Delegate::GetAssociatedTabContents

Issue 1627024: Add ExtensionFunctionDispatcher::Delegate::GetAssociatedTabContents (Closed)

Created:
10 years, 8 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org, Finnur, Aaron Boodman

Visibility:
Public.

Description

Add ExtensionFunctionDispatcher::Delegate::GetAssociatedTabContents. Following work from: http://codereview.chromium.org/1521032/show, based on comments from aa here: http://codereview.chromium.org/1521032/diff/4002/9004#newcode639 BUG=40428 TEST=All tests should pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44680

Patch Set 1 #

Patch Set 2 : pre review #

Total comments: 2

Patch Set 3 : cr changes #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -34 lines)			Patch
M	chrome/browser/extensions/extension_dom_ui.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.h	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.h	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_infobar_delegate.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View	1 2	1 chunk	+3 lines, -32 lines	0 comments	Download
M	chrome/browser/notifications/balloon_host.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

What about popups? They seem like they would have an associated tabcontents. http://codereview.chromium.org/1627024/diff/2001/3004 File chrome/browser/extensions/extension_host.h ...

10 years, 8 months ago (2010-04-15 18:21:44 UTC) #2

Aaron Boodman

On 2010/04/15 18:21:44, Aaron Boodman wrote: > What about popups? They seem like they would ...

10 years, 8 months ago (2010-04-15 18:27:07 UTC) #3

rafaelw

10 years, 8 months ago (2010-04-15 18:36:39 UTC) #4

http://codereview.chromium.org/1627024/diff/2001/3004
File chrome/browser/extensions/extension_host.h (right):

http://codereview.chromium.org/1627024/diff/2001/3004#newcode86
chrome/browser/extensions/extension_host.h:86: virtual TabContents*
GetAssociatedTabContents() {
On 2010/04/15 18:21:44, Aaron Boodman wrote:
> Google style would be associated_tab_contents() and
> set_associated_tab_contents()

Done.

Expand Messages | Collapse Messages