Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1626853005: [Autofill] Trim expiration month select values before converting them to months. (Closed)

Created:
4 years, 11 months ago by Mathieu
Modified:
4 years, 11 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Trim expiration month select values before converting them to months. BUG=555062 TEST=AutofillFieldTest Committed: https://crrev.com/1dbe364799f9ed98c9189dee9499198ca202b5e9 Cr-Commit-Position: refs/heads/master@{#371365}

Patch Set 1 #

Patch Set 2 : more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M components/autofill/core/browser/autofill_field.cc View 1 1 chunk +36 lines, -20 lines 0 comments Download
M components/autofill/core/browser/autofill_field_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Mathieu
Hi Seb, please have a look. P.S. The test is nice :)
4 years, 11 months ago (2016-01-24 04:37:40 UTC) #2
sebsg
On 2016/01/24 04:37:40, Mathieu Perreault wrote: > Hi Seb, please have a look. > > ...
4 years, 11 months ago (2016-01-24 17:47:48 UTC) #3
Mathieu
Hi Roger, can you have a look?
4 years, 11 months ago (2016-01-24 18:30:41 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm
4 years, 11 months ago (2016-01-25 22:32:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626853005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626853005/20001
4 years, 11 months ago (2016-01-25 22:52:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 00:14:05 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:18:28 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1dbe364799f9ed98c9189dee9499198ca202b5e9
Cr-Commit-Position: refs/heads/master@{#371365}

Powered by Google App Engine
This is Rietveld 408576698