components/autofill/core/browser/autofill_field_unittest.cc - Issue 1626853005: [Autofill] Trim expiration month select values before converting them to months.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_field_unittest.cc

Issue 1626853005: [Autofill] Trim expiration month select values before converting them to months. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/autofill_field_unittest.cc

diff --git a/components/autofill/core/browser/autofill_field_unittest.cc b/components/autofill/core/browser/autofill_field_unittest.cc

index 9ef7d7f6744579d6c4cebb3f4cfc33045dfadd1f..6f3b0d40afee46d560cfce19115f76a9e71ec0c9 100644

--- a/components/autofill/core/browser/autofill_field_unittest.cc

+++ b/components/autofill/core/browser/autofill_field_unittest.cc

@@ -470,6 +470,9 @@ TEST_F(AutofillFieldTest, FillSelectControlWithExpirationMonth) {

// Values start at 1.

{{"1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12"},

NotNumericMonthsContentsNoPlaceholder()},

+ // Values start at 1 but single digits are whitespace padded!

+ {{" 1", " 2", " 3", " 4", " 5", " 6", " 7", " 8", " 9", "10", "11", "12"},

+ NotNumericMonthsContentsNoPlaceholder()},

// Values start at 0.

{{"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11"},

NotNumericMonthsContentsNoPlaceholder()},

« no previous file with comments | « components/autofill/core/browser/autofill_field.cc ('k') | no next file » | no next file with comments »