Don't try to use new OTR theming for non-browser-window windows on Linux

Don't try to use new OTR theming for non-browser-window windows on Linux

OTR theming is only supposed to apply to browser window windows (and the
find in page bar), not bubbles or dialogs. The bug only applies to Linux
because of the unique way Linux decides which native theme to use.

BUG=580387
Committed: https://crrev.com/413e1ce857bd9251529f1a6a3cf713d7b04d6bfc
Cr-Commit-Position: refs/heads/master@{#371315}

[Evan Stade, 2016-01-23 03:29:12]

estade@chromium.org changed reviewers:
+ erg@chromium.org, sky@chromium.org

[Evan Stade, 2016-01-23 03:29:13]

https://codereview.chromium.org/1626733002/diff/1/chrome/browser/ui/aura/DEPS
File chrome/browser/ui/aura/DEPS (right):

https://codereview.chromium.org/1626733002/diff/1/chrome/browser/ui/aura/DEPS...
chrome/browser/ui/aura/DEPS:2: "+chrome/browser/ui/views",
Is this ok? Seems like it should be as aura implies views, but I guess I'm not
entirely sure of the motivation for the exclusion of views/ in
chrome/browser/ui/DEPS.

[Evan Stade, 2016-01-23 03:29:17]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-23 03:29:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626733002/1

[commit-bot: I haz the power, 2016-01-23 03:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-23 03:37:14]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2016-01-25 16:18:05]

LGTM

https://codereview.chromium.org/1626733002/diff/1/chrome/browser/ui/aura/DEPS
File chrome/browser/ui/aura/DEPS (right):

https://codereview.chromium.org/1626733002/diff/1/chrome/browser/ui/aura/DEPS...
chrome/browser/ui/aura/DEPS:2: "+chrome/browser/ui/views",
On 2016/01/23 03:29:13, Evan Stade wrote:
> Is this ok?

I think this is fine. I'm honestly not sure why at this point we have this
directory at all. I would be inclined to fold directly into views.

> Seems like it should be as aura implies views, but I guess I'm not
> entirely sure of the motivation for the exclusion of views/ in
> chrome/browser/ui/DEPS.

The motivation for the exclusion rule is to ensure cross platform code, like
chrome/browser/ui/browser.cc or chrome/browser/ui/tabs/tab_strip_model.cc
doesn't end up including code in chrome/browser/ui/views.

[Elliot Glaysher, 2016-01-25 18:24:15]

lgtm

[Evan Stade, 2016-01-25 20:00:57]

On 2016/01/25 16:18:05, sky wrote:
> LGTM
> 
> https://codereview.chromium.org/1626733002/diff/1/chrome/browser/ui/aura/DEPS
> File chrome/browser/ui/aura/DEPS (right):
> 
>
https://codereview.chromium.org/1626733002/diff/1/chrome/browser/ui/aura/DEPS...
> chrome/browser/ui/aura/DEPS:2: "+chrome/browser/ui/views",
> On 2016/01/23 03:29:13, Evan Stade wrote:
> > Is this ok?
> 
> I think this is fine. I'm honestly not sure why at this point we have this
> directory at all. I would be inclined to fold directly into views.
> 
> > Seems like it should be as aura implies views, but I guess I'm not
> > entirely sure of the motivation for the exclusion of views/ in
> > chrome/browser/ui/DEPS.
> 
> The motivation for the exclusion rule is to ensure cross platform code, like
> chrome/browser/ui/browser.cc or chrome/browser/ui/tabs/tab_strip_model.cc
> doesn't end up including code in chrome/browser/ui/views.

Wouldn't that most likely cause a compile failure? I suppose a presubmit check
will provide faster feedback than a cq run.

[Evan Stade, 2016-01-25 20:01:14]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-01-25 20:05:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626733002/1

[sky, 2016-01-25 20:17:10]

On Mon, Jan 25, 2016 at 12:00 PM,  <estade@chromium.org> wrote:
> On 2016/01/25 16:18:05, sky wrote:
>>
>> LGTM
>
>
>>
>>
https://codereview.chromium.org/1626733002/diff/1/chrome/browser/ui/aura/DEPS
>> File chrome/browser/ui/aura/DEPS (right):
>
>
>
>
https://codereview.chromium.org/1626733002/diff/1/chrome/browser/ui/aura/DEPS...
>>
>> chrome/browser/ui/aura/DEPS:2: "+chrome/browser/ui/views",
>> On 2016/01/23 03:29:13, Evan Stade wrote:
>> > Is this ok?
>
>
>> I think this is fine. I'm honestly not sure why at this point we have this
>> directory at all. I would be inclined to fold directly into views.
>
>
>> > Seems like it should be as aura implies views, but I guess I'm not
>> > entirely sure of the motivation for the exclusion of views/ in
>> > chrome/browser/ui/DEPS.
>
>
>> The motivation for the exclusion rule is to ensure cross platform code,
>> like
>> chrome/browser/ui/browser.cc or chrome/browser/ui/tabs/tab_strip_model.cc
>> doesn't end up including code in chrome/browser/ui/views.
>
>
> Wouldn't that most likely cause a compile failure?

You mean a link error? Not sure. The DEP was added as at one point we
had such dependencies.

  -Scott

 I suppose a presubmit
> check
> will provide faster feedback than a cq run.
>
> https://codereview.chromium.org/1626733002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-01-25 21:23:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-25 21:24:44]

Description was changed from

==========
Don't try to use new OTR theming for non-browser-window windows on Linux

OTR theming is only supposed to apply to browser window windows (and the
find in page bar), not bubbles or dialogs. The bug only applies to Linux
because of the unique way Linux decides which native theme to use.

BUG=580387
==========

to

==========
Don't try to use new OTR theming for non-browser-window windows on Linux

OTR theming is only supposed to apply to browser window windows (and the
find in page bar), not bubbles or dialogs. The bug only applies to Linux
because of the unique way Linux decides which native theme to use.

BUG=580387

Committed: https://crrev.com/413e1ce857bd9251529f1a6a3cf713d7b04d6bfc
Cr-Commit-Position: refs/heads/master@{#371315}
==========

[commit-bot: I haz the power, 2016-01-25 21:24:45]

Patchset 1 (id:??) landed as
https://crrev.com/413e1ce857bd9251529f1a6a3cf713d7b04d6bfc
Cr-Commit-Position: refs/heads/master@{#371315}