chrome/browser/ui/aura/DEPS - Issue 1626733002: Don't try to use new OTR theming for non-browser-window windows on Linux

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/aura/DEPS

Issue 1626733002: Don't try to use new OTR theming for non-browser-window windows on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+chrome/browser/ui/views",
	Evan Stade 2016/01/23 03:29:13 Is this ok? Seems like it should be as aura implie Is this ok? Seems like it should be as aura implies views, but I guess I'm not entirely sure of the motivation for the exclusion of views/ in chrome/browser/ui/DEPS. sky 2016/01/25 16:18:04 I think this is fine. I'm honestly not sure why at Show quoted text On 2016/01/23 03:29:13, Evan Stade wrote: > Is this ok? I think this is fine. I'm honestly not sure why at this point we have this directory at all. I would be inclined to fold directly into views. Show quoted text > Seems like it should be as aura implies views, but I guess I'm not > entirely sure of the motivation for the exclusion of views/ in > chrome/browser/ui/DEPS. The motivation for the exclusion rule is to ensure cross platform code, like chrome/browser/ui/browser.cc or chrome/browser/ui/tabs/tab_strip_model.cc doesn't end up including code in chrome/browser/ui/views.
	3 ]

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc » ('j') | no next file with comments »