Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3338)

Unified Diff: net/socket/tcp_socket_win.cc

Issue 1626643002: Remove code to set the send/receive buffer size on XP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove header Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_socket_win.cc
diff --git a/net/socket/tcp_socket_win.cc b/net/socket/tcp_socket_win.cc
index a9998e2c0c6e1b7839fbba2839f5ec53c631fe51..872a56026293cd4c5ee60fba0bcbdb2762c8ec9e 100644
--- a/net/socket/tcp_socket_win.cc
+++ b/net/socket/tcp_socket_win.cc
@@ -13,7 +13,6 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/profiler/scoped_tracker.h"
-#include "base/win/windows_version.h"
#include "net/base/address_list.h"
#include "net/base/connection_type_histograms.h"
#include "net/base/io_buffer.h"
@@ -580,22 +579,6 @@ int TCPSocketWin::SetDefaultOptionsForServer() {
}
void TCPSocketWin::SetDefaultOptionsForClient() {
- // Increase the socket buffer sizes from the default sizes for WinXP. In
- // performance testing, there is substantial benefit by increasing from 8KB
- // to 64KB.
- // See also:
- // http://support.microsoft.com/kb/823764/EN-US
- // On Vista, if we manually set these sizes, Vista turns off its receive
- // window auto-tuning feature.
- // http://blogs.msdn.com/wndp/archive/2006/05/05/Winhec-blog-tcpip-2.aspx
- // Since Vista's auto-tune is better than any static value we can could set,
- // only change these on pre-vista machines.
- if (base::win::GetVersion() < base::win::VERSION_VISTA) {
- const int32_t kSocketBufferSize = 64 * 1024;
- SetSocketReceiveBufferSize(socket_, kSocketBufferSize);
- SetSocketSendBufferSize(socket_, kSocketBufferSize);
- }
-
DisableNagle(socket_, true);
SetTCPKeepAlive(socket_, true, kTCPKeepAliveSeconds);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698