Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 1626423003: Support computed properties for ES2015 Function.name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Mostly working Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/full-codegen/mips64/full-codegen-mips64.cc
diff --git a/src/full-codegen/mips64/full-codegen-mips64.cc b/src/full-codegen/mips64/full-codegen-mips64.cc
index 5b09792e8bb13fe95adac42191323e59b5bb5531..2d4092e0fbf310df2167c71b7421418eb830b827 100644
--- a/src/full-codegen/mips64/full-codegen-mips64.cc
+++ b/src/full-codegen/mips64/full-codegen-mips64.cc
@@ -1649,7 +1649,8 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
if (property->emit_store()) {
__ li(a0, Operand(Smi::FromInt(NONE)));
__ push(a0);
- __ CallRuntime(Runtime::kDefineDataPropertyUnchecked);
+ __ Push(Smi::FromInt(property->NeedsSetFunctionName()));
+ __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);
} else {
__ Drop(3);
}
@@ -2388,7 +2389,10 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {
case ObjectLiteral::Property::PROTOTYPE:
UNREACHABLE();
case ObjectLiteral::Property::COMPUTED:
- __ CallRuntime(Runtime::kDefineClassMethod);
+ __ li(a0, Operand(Smi::FromInt(DONT_ENUM)));
+ __ push(a0);
+ __ Push(Smi::FromInt(property->NeedsSetFunctionName()));
+ __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);
break;
case ObjectLiteral::Property::GETTER:

Powered by Google App Engine
This is Rietveld 408576698