Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 1626423003: Support computed properties for ES2015 Function.name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Mostly working Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1631 matching lines...) Expand 10 before | Expand all | Expand 10 after
1642 EmitSetHomeObject(value, 2, property->GetSlot()); 1642 EmitSetHomeObject(value, 2, property->GetSlot());
1643 } 1643 }
1644 1644
1645 switch (property->kind()) { 1645 switch (property->kind()) {
1646 case ObjectLiteral::Property::CONSTANT: 1646 case ObjectLiteral::Property::CONSTANT:
1647 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1647 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1648 case ObjectLiteral::Property::COMPUTED: 1648 case ObjectLiteral::Property::COMPUTED:
1649 if (property->emit_store()) { 1649 if (property->emit_store()) {
1650 __ li(a0, Operand(Smi::FromInt(NONE))); 1650 __ li(a0, Operand(Smi::FromInt(NONE)));
1651 __ push(a0); 1651 __ push(a0);
1652 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked); 1652 __ Push(Smi::FromInt(property->NeedsSetFunctionName()));
1653 __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);
1653 } else { 1654 } else {
1654 __ Drop(3); 1655 __ Drop(3);
1655 } 1656 }
1656 break; 1657 break;
1657 1658
1658 case ObjectLiteral::Property::PROTOTYPE: 1659 case ObjectLiteral::Property::PROTOTYPE:
1659 UNREACHABLE(); 1660 UNREACHABLE();
1660 break; 1661 break;
1661 1662
1662 case ObjectLiteral::Property::GETTER: 1663 case ObjectLiteral::Property::GETTER:
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
2381 if (NeedsHomeObject(value)) { 2382 if (NeedsHomeObject(value)) {
2382 EmitSetHomeObject(value, 2, property->GetSlot()); 2383 EmitSetHomeObject(value, 2, property->GetSlot());
2383 } 2384 }
2384 2385
2385 switch (property->kind()) { 2386 switch (property->kind()) {
2386 case ObjectLiteral::Property::CONSTANT: 2387 case ObjectLiteral::Property::CONSTANT:
2387 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2388 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2388 case ObjectLiteral::Property::PROTOTYPE: 2389 case ObjectLiteral::Property::PROTOTYPE:
2389 UNREACHABLE(); 2390 UNREACHABLE();
2390 case ObjectLiteral::Property::COMPUTED: 2391 case ObjectLiteral::Property::COMPUTED:
2391 __ CallRuntime(Runtime::kDefineClassMethod); 2392 __ li(a0, Operand(Smi::FromInt(DONT_ENUM)));
2393 __ push(a0);
2394 __ Push(Smi::FromInt(property->NeedsSetFunctionName()));
2395 __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);
2392 break; 2396 break;
2393 2397
2394 case ObjectLiteral::Property::GETTER: 2398 case ObjectLiteral::Property::GETTER:
2395 __ li(a0, Operand(Smi::FromInt(DONT_ENUM))); 2399 __ li(a0, Operand(Smi::FromInt(DONT_ENUM)));
2396 __ push(a0); 2400 __ push(a0);
2397 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked); 2401 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked);
2398 break; 2402 break;
2399 2403
2400 case ObjectLiteral::Property::SETTER: 2404 case ObjectLiteral::Property::SETTER:
2401 __ li(a0, Operand(Smi::FromInt(DONT_ENUM))); 2405 __ li(a0, Operand(Smi::FromInt(DONT_ENUM)));
(...skipping 2409 matching lines...) Expand 10 before | Expand all | Expand 10 after
4811 reinterpret_cast<uint64_t>( 4815 reinterpret_cast<uint64_t>(
4812 isolate->builtins()->OsrAfterStackCheck()->entry())); 4816 isolate->builtins()->OsrAfterStackCheck()->entry()));
4813 return OSR_AFTER_STACK_CHECK; 4817 return OSR_AFTER_STACK_CHECK;
4814 } 4818 }
4815 4819
4816 4820
4817 } // namespace internal 4821 } // namespace internal
4818 } // namespace v8 4822 } // namespace v8
4819 4823
4820 #endif // V8_TARGET_ARCH_MIPS64 4824 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698