command_buffer: Enable gl path rendering by default

command_buffer: Enable gl path rendering by default

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330
Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
Cr-Commit-Position: refs/heads/master@{#371753}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/f5315de75218f1df255da2e5182476aa52ee41cb
Cr-Commit-Position: refs/heads/master@{#378207}

[Kimmo Kinnunen, 2016-01-25 13:35:30]

The CQ bit was checked by kkinnunen@nvidia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 13:35:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626363002/1

[commit-bot: I haz the power, 2016-01-25 13:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 13:35:42]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Kimmo Kinnunen, 2016-01-26 06:50:47]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com, senorblanco@chromium.org, vmiura@chromium.org,
zmo@google.com

[Kimmo Kinnunen, 2016-01-26 06:50:48]

What would it need to get this enabled by default?
We've done some perf profiling and some rudimentary correctness checks. The perf
is ok, and as far as I can tell, the correctness also. Compared to the default
msaa, pixels will vary along the edges of the shapes -- fractional pixels as
well as solid ones.
There's an example perf report attached to the bug.

[Zhenyao Mo, 2016-01-26 18:27:52]

On 2016/01/26 06:50:48, Kimmo Kinnunen wrote:
> What would it need to get this enabled by default?
> We've done some perf profiling and some rudimentary correctness checks. The
perf
> is ok, and as far as I can tell, the correctness also. Compared to the default
> msaa, pixels will vary along the edges of the shapes -- fractional pixels as
> well as solid ones.
> There's an example perf report attached to the bug.

lgtm

[Zhenyao Mo, 2016-01-26 18:28:00]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 18:28:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626363002/1

[vmiura, 2016-01-26 18:30:28]

lgtm

[commit-bot: I haz the power, 2016-01-26 19:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 19:48:44]

Dry run: This issue passed the CQ dry run.

[Kimmo Kinnunen, 2016-01-27 07:33:34]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2016-01-27 07:35:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626363002/1

[commit-bot: I haz the power, 2016-01-27 07:43:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 07:44:40]

Description was changed from

==========
command_buffer: Enable gl path rendering by default

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330
==========

to

==========
command_buffer: Enable gl path rendering by default

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330

Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
Cr-Commit-Position: refs/heads/master@{#371753}
==========

[commit-bot: I haz the power, 2016-01-27 07:44:41]

Patchset 1 (id:??) landed as
https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
Cr-Commit-Position: refs/heads/master@{#371753}

[magjed_chromium, 2016-01-27 10:30:17]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1641623002/ by magjed@chromium.org.

The reason for reverting is: This CL is causing the Linux Release (NVIDIA)
builder to fail:
https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20(NVIDIA)

It fails on step gl_tests on test
GLClearFramebufferTestWithParam/GLClearFramebufferTest.ClearDepthStencil/0 with
this error message:
GLClearFramebufferTestWithParam/GLClearFramebufferTest.ClearDepthStencil/0:
[13969:13969:0126/235302:15239455268986:ERROR:buffer_manager.cc(361)]
[GroupMarkerNotSet(crbug.com/242999)!:C84AD1F190090000]GL ERROR :GL_INVALID_ENUM
: glBufferData: <- error from previous GL command
../../gpu/command_buffer/tests/gl_test_utils.cc:31: Failure
Value of: error
Actual: 1280
Expected: static_cast<GLenum>(0)
Which is: 0
GL ERROR in no errors at line 52 : 1280.

[Kimmo Kinnunen, 2016-01-27 11:56:27]

Description was changed from

==========
command_buffer: Enable gl path rendering by default

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330

Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
Cr-Commit-Position: refs/heads/master@{#371753}
==========

to

==========
command_buffer: Enable gl path rendering by default

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330

Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
Cr-Commit-Position: refs/heads/master@{#371753}
==========

[Kimmo Kinnunen, 2016-02-18 06:07:39]

The CQ bit was checked by kkinnunen@nvidia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 06:08:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626363002/1

[commit-bot: I haz the power, 2016-02-18 06:12:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 06:12:07]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Kimmo Kinnunen, 2016-02-24 13:27:13]

Description was changed from

==========
command_buffer: Enable gl path rendering by default

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330

Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
Cr-Commit-Position: refs/heads/master@{#371753}
==========

to

==========
command_buffer: Enable gl path rendering by default

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330

Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
Cr-Commit-Position: refs/heads/master@{#371753}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Kimmo Kinnunen, 2016-02-24 13:27:40]

The CQ bit was checked by kkinnunen@nvidia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 13:29:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626363002/20001

[commit-bot: I haz the power, 2016-02-24 14:55:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 14:55:53]

Dry run: This issue passed the CQ dry run.

[Kimmo Kinnunen, 2016-02-29 13:00:37]

The original problem wrt the test failure has been fixed now. I've also disabled
NVPR unless mixed samples is present to minimize the potential perf regressions.
I'll try to turn this back on again now.

[Kimmo Kinnunen, 2016-02-29 13:00:51]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2016-02-29 13:00:52]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
vmiura@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1626363002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-29 13:01:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626363002/20001

[commit-bot: I haz the power, 2016-02-29 14:14:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-29 14:15:24]

Description was changed from

==========
command_buffer: Enable gl path rendering by default

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330

Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
Cr-Commit-Position: refs/heads/master@{#371753}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
command_buffer: Enable gl path rendering by default

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330

Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76
Cr-Commit-Position: refs/heads/master@{#371753}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/f5315de75218f1df255da2e5182476aa52ee41cb
Cr-Commit-Position: refs/heads/master@{#378207}
==========

[commit-bot: I haz the power, 2016-02-29 14:15:25]

Patchset 2 (id:??) landed as
https://crrev.com/f5315de75218f1df255da2e5182476aa52ee41cb
Cr-Commit-Position: refs/heads/master@{#378207}