Issue 162633002: aura: Remove an unnecessary parameter from DispatcherClient::RunWithDispatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 162633002: aura: Remove an unnecessary parameter from DispatcherClient::RunWithDispatcher. (Closed)

Created:
6 years, 10 months ago by sadrul

Modified:
6 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+aura_chromium.org, tfarina, kalyank, ben+views_chromium.org, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Remove an unnecessary parameter from DispatcherClient::RunWithDispatcher. The |nestable_tasks_allowed| parameter was always being set to true from the callsites. So get rid of the variable, and use ScopedNestableTaskAllower in the RunWithDispatcher implementations. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251072

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -27 lines)			Patch
M	ash/accelerators/nested_dispatcher_controller.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/accelerators/nested_dispatcher_controller.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	ash/accelerators/nested_dispatcher_controller_unittest.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/first_run_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/simple_message_box_views.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/client/dispatcher_client.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/views/controls/menu/menu_controller_aura.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_dispatcher_client.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_dispatcher_client.cc	View	1 chunk	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 10 months ago (2014-02-13 17:26:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r251072 (presubmit successful).

Expand Messages | Collapse Messages