Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: ui/views/widget/desktop_aura/desktop_dispatcher_client.cc

Issue 162633002: aura: Remove an unnecessary parameter from DispatcherClient::RunWithDispatcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/desktop_aura/desktop_dispatcher_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/desktop_aura/desktop_dispatcher_client.cc
diff --git a/ui/views/widget/desktop_aura/desktop_dispatcher_client.cc b/ui/views/widget/desktop_aura/desktop_dispatcher_client.cc
index 212a6a452e3ba1b4478d5e699afedebae50acb13..be251da5c35cf77329f01eca9ebff2fd1f3bb1dd 100644
--- a/ui/views/widget/desktop_aura/desktop_dispatcher_client.cc
+++ b/ui/views/widget/desktop_aura/desktop_dispatcher_client.cc
@@ -14,21 +14,16 @@ DesktopDispatcherClient::~DesktopDispatcherClient() {}
void DesktopDispatcherClient::RunWithDispatcher(
base::MessagePumpDispatcher* nested_dispatcher,
- aura::Window* associated_window,
- bool nestable_tasks_allowed) {
+ aura::Window* associated_window) {
// TODO(erg): This class has been copypastad from
// ash/accelerators/nested_dispatcher_controller.cc. I have left my changes
// commented out because I don't entirely understand the implications of the
// change.
base::MessageLoopForUI* loop = base::MessageLoopForUI::current();
- bool did_allow_task_nesting = loop->NestableTasksAllowed();
- loop->SetNestableTasksAllowed(nestable_tasks_allowed);
+ base::MessageLoopForUI::ScopedNestableTaskAllower allow_nested(loop);
- // DefaultAcceleratorDispatcher dispatcher(nested_dispatcher,
- // associated_window);
base::RunLoop run_loop(nested_dispatcher);
run_loop.Run();
- loop->SetNestableTasksAllowed(did_allow_task_nesting);
}
} // namespace views
« no previous file with comments | « ui/views/widget/desktop_aura/desktop_dispatcher_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698