Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1625993002: Mark opener extension port as opened after creation (Closed)

Created:
4 years, 11 months ago by robwu
Modified:
4 years, 11 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark opener extension port as opened after creation Mark an opener port as opened upon creation, to prevent an error from showing up when all receiver ports are implicitly closed (e.g. by navigation). BUG=580882 Committed: https://crrev.com/2d89d1733cecd8a88236c943e8a4be4e060dc5ac Cr-Commit-Position: refs/heads/master@{#371303}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
robwu
Hi Matt, small change, PTAL! https://codereview.chromium.org/1629013002/ depends on this.
4 years, 11 months ago (2016-01-24 20:44:07 UTC) #2
Matt Perry
lgtm
4 years, 11 months ago (2016-01-25 19:10:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625993002/1
4 years, 11 months ago (2016-01-25 19:11:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 20:38:28 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 20:39:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d89d1733cecd8a88236c943e8a4be4e060dc5ac
Cr-Commit-Position: refs/heads/master@{#371303}

Powered by Google App Engine
This is Rietveld 408576698