chrome/test/data/extensions/api_test/messaging/connect/page.js - Issue 1625993002: Mark opener extension port as opened after creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/messaging/connect/page.js

Issue 1625993002: Mark opener extension port as opened after creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/message_service.cc ('k') | chrome/test/data/extensions/api_test/messaging/connect/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/messaging/connect/page.js

diff --git a/chrome/test/data/extensions/api_test/messaging/connect/page.js b/chrome/test/data/extensions/api_test/messaging/connect/page.js

index bf122e7a9157e6f72809b5b348d3f06060e3911a..eef9fc6ddae32881234ddd476d1fb29e09511764 100644

--- a/chrome/test/data/extensions/api_test/messaging/connect/page.js

+++ b/chrome/test/data/extensions/api_test/messaging/connect/page.js

@@ -40,7 +40,10 @@ chrome.runtime.onConnect.addListener(function onConnect(port) {

chrome.test.assertFalse(chrome.runtime.onConnect.hasListeners());

testConnectChildFrameAndNavigateSetup();

} else if (msg.testDisconnectOnClose) {

- window.location = "about:blank";

+ chrome.runtime.connect().onMessage.addListener(function(msg) {

+ chrome.test.assertEq('unloadTabContent', msg);

+ window.location = 'about:blank';

+ });

} else if (msg.testPortName) {

port.postMessage({portName:port.name});

} else if (msg.testSendMessageFromTabError) {