Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1625633003: Make IsWKWebViewEnabled not query field trial, command line flags. (Closed)

Created:
4 years, 11 months ago by shreyasv1
Modified:
4 years, 10 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make IsWKWebViewEnabled not query field trial, command line flags. BUG=579249 Committed: https://crrev.com/f932e393d8d0f1016f19cf142ab4a5ff21cf8cac Cr-Commit-Position: refs/heads/master@{#371818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M ios/chrome/browser/experimental_flags.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +1 line, -21 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
shreyasv1
4 years, 11 months ago (2016-01-22 21:51:43 UTC) #2
shreyasv1
I'll make follow clean up CLs.
4 years, 11 months ago (2016-01-22 21:58:21 UTC) #3
shreyasv1
On 2016/01/22 21:58:21, shreyasv1 wrote: > I'll make follow clean up CLs. Follow-up*
4 years, 11 months ago (2016-01-22 21:58:32 UTC) #4
shreyasv1
+Stuart, incase he can turn it around faster.
4 years, 11 months ago (2016-01-26 19:59:08 UTC) #6
rohitrao (ping after 24h)
lgtm
4 years, 11 months ago (2016-01-27 13:29:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625633003/1
4 years, 11 months ago (2016-01-27 17:26:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 17:49:57 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 17:51:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f932e393d8d0f1016f19cf142ab4a5ff21cf8cac
Cr-Commit-Position: refs/heads/master@{#371818}

Powered by Google App Engine
This is Rietveld 408576698