Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: ios/chrome/browser/experimental_flags.mm

Issue 1625633003: Make IsWKWebViewEnabled not query field trial, command line flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/experimental_flags.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/experimental_flags.mm
diff --git a/ios/chrome/browser/experimental_flags.mm b/ios/chrome/browser/experimental_flags.mm
index b6c537c9d1b0c9084b6c28cbe80334e36518a8cb..c266823bfe3f3fa95890090d936089cfc2493529 100644
--- a/ios/chrome/browser/experimental_flags.mm
+++ b/ios/chrome/browser/experimental_flags.mm
@@ -142,27 +142,7 @@ bool CanCheckWKWebViewExperiment() {
}
bool IsWKWebViewEnabled() {
- if (!CanCheckWKWebViewExperiment()) {
- return false;
- }
-
- // Now that it's been established that user is a candidate, set up the trial
- // by checking the group.
- std::string group_name =
- base::FieldTrialList::FindFullName(kWKWebViewTrialName);
-
- // Check if the experimental flag is turned on.
- base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
- if (command_line->HasSwitch(switches::kEnableIOSWKWebView))
- return true;
- else if (command_line->HasSwitch(switches::kDisableIOSWKWebView))
- return false;
-
- // Check if the finch experiment is turned on.
- return !base::StartsWith(group_name, "Disabled",
- base::CompareCase::INSENSITIVE_ASCII) &&
- !base::StartsWith(group_name, "Control",
- base::CompareCase::INSENSITIVE_ASCII);
+ return true;
}
bool IsTargetedToWKWebViewExperimentControlGroup() {
« no previous file with comments | « ios/chrome/browser/experimental_flags.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698