Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: content/browser/indexed_db/indexed_db_backing_store_unittest.cc

Issue 16256014: IndexedDB: Convert decoding functions to pass StringPieces vs. pointers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_backing_store_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
index fbef9819932c454d80ec9bb10f8340523e955dca..235e4865a485e16902cc55d429acfbf66bf0e691 100644
--- a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
@@ -90,7 +90,8 @@ TEST_F(IndexedDBBackingStoreTest, HighIds) {
const int64 invalid_high_index_id = 1ULL << 37;
const IndexedDBKey& index_key = m_key2;
- std::vector<char> index_key_raw = EncodeIDBKey(index_key);
+ std::vector<char> index_key_raw;
+ EncodeIDBKey(index_key, &index_key_raw);
{
IndexedDBBackingStore::Transaction transaction1(backing_store_.get());
transaction1.begin();
@@ -379,22 +380,22 @@ TEST(IndexedDBFactoryTest, MemoryBackingStoreLifetime) {
scoped_refptr<MockIDBFactory> factory = MockIDBFactory::Create();
scoped_refptr<IndexedDBBackingStore> mem_store1 =
factory->TestOpenBackingStore(origin1, base::FilePath());
- EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1 and factory
+ EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1 and factory
scoped_refptr<IndexedDBBackingStore> mem_store2 =
factory->TestOpenBackingStore(origin1, base::FilePath());
EXPECT_EQ(mem_store1.get(), mem_store2.get());
- EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1, 2 and factory
- EXPECT_FALSE(mem_store2->HasOneRef()); // mem_store1, 2 and factory
+ EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1, 2 and factory
+ EXPECT_FALSE(mem_store2->HasOneRef()); // mem_store1, 2 and factory
scoped_refptr<IndexedDBBackingStore> mem_store3 =
factory->TestOpenBackingStore(origin2, base::FilePath());
- EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1, 2 and factory
- EXPECT_FALSE(mem_store3->HasOneRef()); // mem_store3 and factory
+ EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1, 2 and factory
+ EXPECT_FALSE(mem_store3->HasOneRef()); // mem_store3 and factory
factory = NULL;
- EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1 and 2
- EXPECT_FALSE(mem_store2->HasOneRef()); // mem_store1 and 2
+ EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1 and 2
+ EXPECT_FALSE(mem_store2->HasOneRef()); // mem_store1 and 2
EXPECT_TRUE(mem_store3->HasOneRef());
mem_store2 = NULL;

Powered by Google App Engine
This is Rietveld 408576698