IndexedDB: Convert decoding functions to pass StringPieces vs. pointers

content/browser/indexed_db/indexed_db_backing_store_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/logging.h"
 #include "base/string16.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 72 matching lines @@
 // and object_store_id still work.
 TEST_F(IndexedDBBackingStoreTest, HighIds) {
   const int64 high_database_id = 1ULL << 35;
   const int64 high_object_store_id = 1ULL << 39;
   // index_ids are capped at 32 bits for storage purposes.
   const int64 high_index_id = 1ULL << 29;
 
   const int64 invalid_high_index_id = 1ULL << 37;
 
   const IndexedDBKey& index_key = m_key2;
-  std::vector<char> index_key_raw = EncodeIDBKey(index_key);
+  std::vector<char> index_key_raw;
+  EncodeIDBKey(index_key, &index_key_raw);
   {
     IndexedDBBackingStore::Transaction transaction1(backing_store_.get());
     transaction1.begin();
     IndexedDBBackingStore::RecordIdentifier record;
     bool ok = backing_store_->PutRecord(&transaction1,
                                         high_database_id,
                                         high_object_store_id,
                                         m_key1,
                                         m_value1,
                                         &record);
@@ skipping 268 matching lines @@
 
 TEST(IndexedDBFactoryTest, MemoryBackingStoreLifetime) {
   WebSecurityOrigin origin1 =
       WebSecurityOrigin::createFromString("http://localhost:81");
   WebSecurityOrigin origin2 =
       WebSecurityOrigin::createFromString("http://localhost:82");
 
   scoped_refptr<MockIDBFactory> factory = MockIDBFactory::Create();
   scoped_refptr<IndexedDBBackingStore> mem_store1 =
       factory->TestOpenBackingStore(origin1, base::FilePath());
-  EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1 and factory
+  EXPECT_FALSE(mem_store1->HasOneRef());  // mem_store1 and factory
 
   scoped_refptr<IndexedDBBackingStore> mem_store2 =
       factory->TestOpenBackingStore(origin1, base::FilePath());
   EXPECT_EQ(mem_store1.get(), mem_store2.get());
-  EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1, 2 and factory
-  EXPECT_FALSE(mem_store2->HasOneRef()); // mem_store1, 2 and factory
+  EXPECT_FALSE(mem_store1->HasOneRef());  // mem_store1, 2 and factory
+  EXPECT_FALSE(mem_store2->HasOneRef());  // mem_store1, 2 and factory
 
   scoped_refptr<IndexedDBBackingStore> mem_store3 =
       factory->TestOpenBackingStore(origin2, base::FilePath());
-  EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1, 2 and factory
-  EXPECT_FALSE(mem_store3->HasOneRef()); // mem_store3 and factory
+  EXPECT_FALSE(mem_store1->HasOneRef());  // mem_store1, 2 and factory
+  EXPECT_FALSE(mem_store3->HasOneRef());  // mem_store3 and factory
 
   factory = NULL;
-  EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1 and 2
-  EXPECT_FALSE(mem_store2->HasOneRef()); // mem_store1 and 2
+  EXPECT_FALSE(mem_store1->HasOneRef());  // mem_store1 and 2
+  EXPECT_FALSE(mem_store2->HasOneRef());  // mem_store1 and 2
   EXPECT_TRUE(mem_store3->HasOneRef());
 
   mem_store2 = NULL;
   EXPECT_TRUE(mem_store1->HasOneRef());
 }
 
 }  // namespace
 
 }  // namespace content