Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1625473002: compositor-worker: blink->cc plumbing

Created:
4 years, 11 months ago by flackr
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+worker_chromium.org, kinuko+watch, danakj+watch_chromium.org, rwlbuis, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, jam, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, blink-reviews, darin-cc_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, vmpstr+blinkwatch_chromium.org, sof, jbroman, loading-reviews_chromium.org, krit, piman+watch_chromium.org, Nate Chapin, Stephen Chennney, tyoshino+watch_chromium.org, falken, f(malita), mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@upstream-compositor-worker
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

compositor-worker: blink->cc plumbing Add plumbing connecting CompositorProxy to cc via CompositorMutatorImpl. BUG=436952 TEST=virtual/threaded/fast/compositorworker CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Patch Set 2 : Fix timing issue with sending updates to worker by delaying one rAF #

Patch Set 3 : Merge with landing of https://codereview.chromium.org/1599673002/ on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1242 lines, -56 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A cc/animation/layer_tree_mutator.h View 1 chunk +38 lines, -0 lines 0 comments Download
M cc/animation/mutable_properties.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/channel_main.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 6 chunks +10 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 6 chunks +29 lines, -0 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 2 5 chunks +8 lines, -1 line 0 comments Download
M cc/trees/proxy.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/proxy_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/proxy_impl.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M cc/trees/proxy_main.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/proxy_main.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/threaded_channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/threaded_channel.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/threaded/compositing/compositor-worker/README.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/basic-plumbing-main-to-worker.html View 1 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/basic-plumbing-main-to-worker.js View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/basic-plumbing-main-to-worker-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/basic-plumbing-worker-to-main.html View 1 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/basic-plumbing-worker-to-main.js View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/basic-plumbing-worker-to-main-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-worker-postmessage.html View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/basic-plumbing-main-to-worker.js View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/basic-plumbing-worker-to-main.js View 1 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/visual-update.js View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/visual-update.html View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/visual-update-expected.html View 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.h View 4 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.cpp View 1 2 10 chunks +67 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.idl View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/CompositorProxyClient.h View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/CompositorProxyClient.cpp View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 3 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 3 chunks +16 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutation.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/Source/platform/graphics/CompositorMutator.h View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.cpp View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformationMatrix.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/CompositorMutatorImpl.h View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/CompositorMutatorImpl.cpp View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/CompositorProxyClientImpl.h View 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp View 1 chunk +126 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebCompositorMutatorClient.h View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 2 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1602343002 Patch 40001

Powered by Google App Engine
This is Rietveld 408576698