Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1625213003: Update messages, and fix typing in test. (Closed)

Created:
4 years, 11 months ago by floitsch
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/generated/shared_messages.dart View 1 chunk +1 line, -1 line 2 comments Download
M pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dart_messages/lib/generated/shared_messages.json View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
floitsch
TBR.
4 years, 11 months ago (2016-01-25 12:40:56 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 5cb3da473b6d61b96a802d1d26d1051fba57696f (presubmit successful).
4 years, 11 months ago (2016-01-25 12:41:09 UTC) #4
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1625213003/diff/1/pkg/analyzer/lib/src/generated/generated/shared_messages.dart File pkg/analyzer/lib/src/generated/generated/shared_messages.dart (right): https://codereview.chromium.org/1625213003/diff/1/pkg/analyzer/lib/src/generated/generated/shared_messages.dart#newcode2 pkg/analyzer/lib/src/generated/generated/shared_messages.dart:2: DON'T EDIT. GENERATED. DON'T EDIT. Have we checked ...
4 years, 11 months ago (2016-01-25 13:44:01 UTC) #5
floitsch
4 years, 11 months ago (2016-01-25 15:13:34 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1625213003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/generated/shared_messages.dart (right):

https://codereview.chromium.org/1625213003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/generated/shared_messages.dart:2: DON'T EDIT.
GENERATED. DON'T EDIT.
On 2016/01/25 13:44:01, Lasse Reichstein Nielsen wrote:
> Have we checked that it's OK to have things above the copyright notice?

Couldn't find anything to the contrary.
In some cases, there must even be something before:

#!/bin/bash
#
# Copyright 2010 XYZ. All Rights Reserved.

But switching order in a follow-up CL.

Powered by Google App Engine
This is Rietveld 408576698