tests/compiler/dart2js/message_kind_test.dart - Issue 1625213003: Update messages, and fix typing in test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/message_kind_test.dart

Issue 1625213003: Update messages, and fix typing in test. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/message_kind_test.dart

diff --git a/tests/compiler/dart2js/message_kind_test.dart b/tests/compiler/dart2js/message_kind_test.dart

index 9cd634f9b320ac0478193324993a943c2848541c..a886f42b0a77d12b4f9cdf68bb0e54164564cd7c 100644

--- a/tests/compiler/dart2js/message_kind_test.dart

+++ b/tests/compiler/dart2js/message_kind_test.dart

@@ -14,8 +14,9 @@ import 'message_kind_helper.dart';

main(List<String> arguments) {

List<MessageTemplate> examples = <MessageTemplate>[];

- List allMessageKinds =

- MessageKind.values.toList()..addAll(SharedMessageKind.values);

+ List allMessageKinds = []

+ ..addAll(MessageKind.values)

+ ..addAll(SharedMessageKind.values);

Lasse Reichstein Nielsen 2016/01/25 13:44:01 Wouldn't it be great if we had List.operator+? :)

for (var kind in allMessageKinds) {

if (kind == SharedMessageKind.exampleMessage) continue;