Clean up frame code a bit:

Clean up frame code a bit:

* Make more functions const
* Tweak version check to "< Win 10" to match code constant names and the pattern of how we check this elsewhere in the UI code
* Rename some things from "avatar" to "incognito icon"
* Remove unnecessary member
* Replace local constants with layout constants (only in cases where the layout constants have the same values in non-MD)
* Simplify.  In a few cases this may look like a behavior change but isn't; e.g. "NonClientTopBorderHeight(false) + kTabstripTopShadowThickness" was replaced by "FrameBorderThickness(false)" at a place where the two are guaranteed to be the same value
* Prepare for further tabstrip/incognito icon positioning fixes to OpaqueBrowserFrameViewLayout::LayoutIncognitoIcon()

BUG=none
TEST=none

Committed: https://crrev.com/11bb4163516d0d4580875a3eab247eb872b7256f
Cr-Commit-Position: refs/heads/master@{#371432}

[Peter Kasting, 2016-01-23 01:48:54]

Description was changed from

==========
Clean up frame code a bit:

BUG=none
TEST=none
==========

to

==========
Clean up frame code a bit:

* Make more functions const
* Tweak version check to "< Win 10" to match code constant names and the pattern
of how we check this elsewhere in the UI code
* Rename some things from "avatar" to "incognito icon"
* Remove unnecessary member
* Replace local constants with layout constants (only in cases where the layout
constants have the same values in non-MD)
* Simplify.  In a few cases this may look like a behavior change but isn't; e.g.
"NonClientTopBorderHeight(false) + kTabstripTopShadowThickness" was replaced by
"FrameBorderThickness(false)" at a place where the two are guaranteed to be the
same value
* Prepare for further tabstrip/incognito icon positioning fixes to
OpaqueBrowserFrameViewLayout::LayoutIncognitoIcon()

BUG=none
TEST=none
==========

[Peter Kasting, 2016-01-23 01:48:54]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-01-25 16:08:54]

LGTM

[Peter Kasting, 2016-01-26 01:49:59]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-01-26 01:50:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1624773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1624773002/40001

[commit-bot: I haz the power, 2016-01-26 02:51:17]

Description was changed from

==========
Clean up frame code a bit:

* Make more functions const
* Tweak version check to "< Win 10" to match code constant names and the pattern
of how we check this elsewhere in the UI code
* Rename some things from "avatar" to "incognito icon"
* Remove unnecessary member
* Replace local constants with layout constants (only in cases where the layout
constants have the same values in non-MD)
* Simplify.  In a few cases this may look like a behavior change but isn't; e.g.
"NonClientTopBorderHeight(false) + kTabstripTopShadowThickness" was replaced by
"FrameBorderThickness(false)" at a place where the two are guaranteed to be the
same value
* Prepare for further tabstrip/incognito icon positioning fixes to
OpaqueBrowserFrameViewLayout::LayoutIncognitoIcon()

BUG=none
TEST=none
==========

to

==========
Clean up frame code a bit:

* Make more functions const
* Tweak version check to "< Win 10" to match code constant names and the pattern
of how we check this elsewhere in the UI code
* Rename some things from "avatar" to "incognito icon"
* Remove unnecessary member
* Replace local constants with layout constants (only in cases where the layout
constants have the same values in non-MD)
* Simplify.  In a few cases this may look like a behavior change but isn't; e.g.
"NonClientTopBorderHeight(false) + kTabstripTopShadowThickness" was replaced by
"FrameBorderThickness(false)" at a place where the two are guaranteed to be the
same value
* Prepare for further tabstrip/incognito icon positioning fixes to
OpaqueBrowserFrameViewLayout::LayoutIncognitoIcon()

BUG=none
TEST=none
==========

[commit-bot: I haz the power, 2016-01-26 02:51:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-26 02:52:38]

Description was changed from

==========
Clean up frame code a bit:

* Make more functions const
* Tweak version check to "< Win 10" to match code constant names and the pattern
of how we check this elsewhere in the UI code
* Rename some things from "avatar" to "incognito icon"
* Remove unnecessary member
* Replace local constants with layout constants (only in cases where the layout
constants have the same values in non-MD)
* Simplify.  In a few cases this may look like a behavior change but isn't; e.g.
"NonClientTopBorderHeight(false) + kTabstripTopShadowThickness" was replaced by
"FrameBorderThickness(false)" at a place where the two are guaranteed to be the
same value
* Prepare for further tabstrip/incognito icon positioning fixes to
OpaqueBrowserFrameViewLayout::LayoutIncognitoIcon()

BUG=none
TEST=none
==========

to

==========
Clean up frame code a bit:

* Make more functions const
* Tweak version check to "< Win 10" to match code constant names and the pattern
of how we check this elsewhere in the UI code
* Rename some things from "avatar" to "incognito icon"
* Remove unnecessary member
* Replace local constants with layout constants (only in cases where the layout
constants have the same values in non-MD)
* Simplify.  In a few cases this may look like a behavior change but isn't; e.g.
"NonClientTopBorderHeight(false) + kTabstripTopShadowThickness" was replaced by
"FrameBorderThickness(false)" at a place where the two are guaranteed to be the
same value
* Prepare for further tabstrip/incognito icon positioning fixes to
OpaqueBrowserFrameViewLayout::LayoutIncognitoIcon()

BUG=none
TEST=none

Committed: https://crrev.com/11bb4163516d0d4580875a3eab247eb872b7256f
Cr-Commit-Position: refs/heads/master@{#371432}
==========

[commit-bot: I haz the power, 2016-01-26 02:52:39]

Patchset 3 (id:??) landed as
https://crrev.com/11bb4163516d0d4580875a3eab247eb872b7256f
Cr-Commit-Position: refs/heads/master@{#371432}