Clean up frame code a bit:

chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h"
 
 #include "base/command_line.h"
 #include "build/build_config.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/ui/layout_constants.h"
@@ skipping 24 matching lines @@
 
 // The titlebar has a 2 px 3D edge along the top and bottom.
 const int kTitlebarTopAndBottomEdgeThickness = 2;
 
 // The icon is inset 2 px from the left frame border.
 const int kIconLeftSpacing = 2;
 
 // There is a 4 px gap between the icon and the title text.
 const int kIconTitleSpacing = 4;
 
-// The avatar ends 2 px above the bottom of the tabstrip (which, given the
-// way the tabstrip draws its bottom edge, will appear like a 1 px gap to the
-// user).
-const int kAvatarBottomSpacing = 2;
-
-// Space between the frame border and the edge of the avatar.
-const int kAvatarOuterSpacing = 2;
-
 // Space between the edge of the avatar and the tabstrip.
 const int kAvatarInnerSpacing = 4;
 
 // How far the new avatar button is from the closest caption button.
 const int kNewAvatarButtonOffset = 5;
 
 // When the title bar is in its normal two row mode (usually the case for
 // restored windows), the New Tab button isn't at the same height as the caption
 // buttons, but the space will look cluttered if it actually slides under them,
 // so we stop it when the gap between the two is down to 5 px.
 const int kNewTabCaptionNormalSpacing = 5;
 
 // When the title bar is condensed to one row (as when maximized), the New Tab
 // button and the caption buttons are at similar vertical coordinates, so we
 // need to reserve a larger, 16 px gap to avoid looking too cluttered.
 const int kNewTabCaptionCondensedSpacing = 16;
 
 // If there are no caption buttons to the right of the New Tab button, we
 // reserve a small 5px gap, regardless of whether the window is maximized. This
 // overrides the two previous constants.
 const int kNewTabNoCaptionButtonsSpacing = 5;
 
-// The top 3 px of the tabstrip is shadow; in maximized mode we push this off
-// the top of the screen so the tabs appear flush against the screen edge.
-const int kTabstripTopShadowThickness = 3;
-
-// How far to indent the tabstrip from the left side of the screen when there
-// is no avatar icon.
-const int kTabStripIndent = -6;
-
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
 // Default extra space between the top of the frame and the top of the window
 // caption buttons.
 const int kExtraCaption = 2;
 
 // Default extra spacing between individual window caption buttons.
 const int kCaptionButtonSpacing = 2;
 #else
 const int kExtraCaption = 0;
 const int kCaptionButtonSpacing = 0;
@@ skipping 32 matching lines @@
 void OpaqueBrowserFrameViewLayout::SetButtonOrdering(
     const std::vector<views::FrameButton>& leading_buttons,
     const std::vector<views::FrameButton>& trailing_buttons) {
   leading_buttons_ = leading_buttons;
   trailing_buttons_ = trailing_buttons;
 }
 
 gfx::Rect OpaqueBrowserFrameViewLayout::GetBoundsForTabStrip(
     const gfx::Size& tabstrip_preferred_size,
     int available_width) const {
-  available_width -= trailing_button_start_;
-  available_width -= leading_button_start_;
-
-  const int caption_spacing = NewTabCaptionSpacing();
-  const int tabstrip_width = available_width - caption_spacing;
-  gfx::Rect bounds(leading_button_start_, GetTabStripInsetsTop(false),
-                   std::max(0, tabstrip_width),
+  int x = leading_button_start_ + GetLayoutInsets(AVATAR_ICON).right();
+  available_width -= x + NewTabCaptionSpacing() + trailing_button_start_;
+  gfx::Rect bounds(x, GetTabStripInsetsTop(false), std::max(0, available_width),
                    tabstrip_preferred_size.height());
 
-  int leading_tabstrip_indent = kTabStripIndent;
-  if (delegate_->ShouldShowAvatar() && !ShouldAvatarBeOnRight())
-    leading_tabstrip_indent += kAvatarInnerSpacing;
-  bounds.Inset(leading_tabstrip_indent, 0, 0, 0);
+  if (delegate_->ShouldShowAvatar() && !ShouldIncognitoIconBeOnRight())
+    bounds.Inset(kAvatarInnerSpacing, 0, 0, 0);
   return bounds;
 }
 
 gfx::Size OpaqueBrowserFrameViewLayout::GetMinimumSize(
     int available_width) const {
   gfx::Size min_size = delegate_->GetBrowserViewMinimumSize();
   int border_thickness = NonClientBorderThickness();
   min_size.Enlarge(2 * border_thickness,
                    NonClientTopBorderHeight(false) + border_thickness);
 
@@ skipping 100 matching lines @@
 bool OpaqueBrowserFrameViewLayout::IsTitleBarCondensed() const {
   // If there are no caption buttons, there is no need to have an uncondensed
   // title bar. If the window is maximized, the title bar is condensed
   // regardless of whether there are caption buttons.
   return !delegate_->ShouldShowCaptionButtons() || delegate_->IsMaximized();
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // OpaqueBrowserFrameView, private:
 
-bool OpaqueBrowserFrameViewLayout::ShouldAvatarBeOnRight() const {
-  // The avatar should be shown either on the end of the left or the beginning
-  // of the right depending on which side has fewer buttons.
+bool OpaqueBrowserFrameViewLayout::ShouldIncognitoIconBeOnRight() const {
+  // The incognito should be shown either on the end of the left or the
+  // beginning of the right, depending on which side has fewer buttons.
   return trailing_buttons_.size() < leading_buttons_.size();
 }
 
 int OpaqueBrowserFrameViewLayout::NewTabCaptionSpacing() const {
   if (!has_trailing_buttons_)
     return kNewTabNoCaptionButtonsSpacing;
   return IsTitleBarCondensed() ?
       kNewTabCaptionCondensedSpacing : kNewTabCaptionNormalSpacing;
 }
 
@@ skipping 117 matching lines @@
   // the avatar button.
   if (!IsTitleBarCondensed()) {
     trailing_button_start_ -=
         GetLayoutSize(NEW_TAB_BUTTON).width() + kNewTabCaptionNormalSpacing;
   }
 
   new_avatar_button_->SetBounds(button_x, button_y, button_width,
                                 kCaptionButtonHeight);
 }
 
-void OpaqueBrowserFrameViewLayout::LayoutAvatar(views::View* host) {
-  // Even though the avatar is used for both incognito and profiles we always
-  // use the incognito icon to layout the avatar button. The profile icon
-  // can be customized so we can't depend on its size to perform layout.
-  gfx::ImageSkia incognito_icon = delegate_->GetOTRAvatarIcon();
+void OpaqueBrowserFrameViewLayout::LayoutIncognitoIcon(views::View* host) {
+  const int old_button_size = leading_button_start_ + trailing_button_start_;
 
-  bool avatar_on_right = ShouldAvatarBeOnRight();
-  int avatar_bottom = GetTabStripInsetsTop(false) +
-      delegate_->GetTabStripHeight() - kAvatarBottomSpacing;
-  int avatar_restored_y = avatar_bottom - incognito_icon.height();
-  int avatar_x = avatar_on_right ?
-      host->width() - trailing_button_start_ - kAvatarOuterSpacing -
-          incognito_icon.width() :
-      leading_button_start_ + kAvatarOuterSpacing;
-  int avatar_y = IsTitleBarCondensed() ?
-      (NonClientTopBorderHeight(false) + kTabstripTopShadowThickness) :
-      avatar_restored_y;
-  avatar_bounds_.SetRect(
-      avatar_x,
-      avatar_y,
-      incognito_icon.width(),
-      delegate_->ShouldShowAvatar() ? (avatar_bottom - avatar_y) : 0);
   if (avatar_button_) {
-    avatar_button_->SetBoundsRect(avatar_bounds_);
+    const gfx::Insets insets(GetLayoutInsets(AVATAR_ICON));
+    const gfx::Size size(delegate_->GetOTRAvatarIcon().size());
+    const int incognito_width = insets.left() + size.width();
+    int x;
+    if (ShouldIncognitoIconBeOnRight()) {
+      trailing_button_start_ += incognito_width;
+      x = host->width() - trailing_button_start_;
+    } else {
+      x = leading_button_start_ + insets.left();
+      leading_button_start_ += incognito_width;
+    }
+    const int bottom = GetTabStripInsetsTop(false) +
+        delegate_->GetTabStripHeight() - insets.bottom();
+    int y = IsTitleBarCondensed() ?
+        FrameBorderThickness(false) : (bottom - size.height());
+    avatar_button_->SetBounds(x, y, size.width(), bottom - y);
+  }
 
-    int edge_offset = kAvatarOuterSpacing + incognito_icon.width();
-    if (avatar_on_right)
-      trailing_button_start_ += edge_offset;
-    else
-      leading_button_start_ += edge_offset;
-
-    // We just add the avatar button size to the minimum size because clicking
-    // the avatar label does the same thing as clicking the avatar button.
-    minimum_size_for_buttons_ += kAvatarOuterSpacing + incognito_icon.width();
-  }
+  minimum_size_for_buttons_ +=
+      (leading_button_start_ + trailing_button_start_ - old_button_size);
 }
 
 void OpaqueBrowserFrameViewLayout::ConfigureButton(
     views::View* host,
     views::FrameButton button_id,
     ButtonAlignment alignment,
     int caption_y) {
   switch (button_id) {
     case views::FRAME_BUTTON_MINIMIZE: {
       minimize_button_->SetVisible(true);
@@ skipping 187 matching lines @@
   LayoutTitleBar(host);
 
   // We now add a single pixel to the leading spacing. We do this because the
   // avatar and tab strip start one pixel inward compared to where things start
   // on the trailing side.
   leading_button_start_++;
 
   if (delegate_->IsRegularOrGuestSession())
     LayoutNewStyleAvatar(host);
   else
-    LayoutAvatar(host);
+    LayoutIncognitoIcon(host);
 
   client_view_bounds_ = CalculateClientAreaBounds(
       host->width(), host->height());
 }
 
 gfx::Size OpaqueBrowserFrameViewLayout::GetPreferredSize(
     const views::View* host) const {
   // This is never used; NonClientView::GetPreferredSize() will be called
   // instead.
   NOTREACHED();
   return gfx::Size();
 }
 
 void OpaqueBrowserFrameViewLayout::ViewAdded(views::View* host,
                                              views::View* view) {
   SetView(view->id(), view);
 }
 
 void OpaqueBrowserFrameViewLayout::ViewRemoved(views::View* host,
                                                views::View* view) {
   SetView(view->id(), nullptr);
 }