Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1624633002: Prevent creation of gpu channels with no GPU on x86-64 windows (Closed)

Created:
4 years, 11 months ago by jbauman
Modified:
4 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent creation of gpu channels with no GPU on x86-64 windows https://codereview.chromium.org/1575293002 allowed GPU contexts to be created even when the browser can't use the GPU (for use with swiftshader). However, this seems to be causing renderer hangs on x86-64 windows, so disable it there. Swiftshader currently doesn't work on x86-64 anyway, so it won't affect functionality. BUG=577127 Committed: https://crrev.com/25c4ff976aa6b53c29832d0615e40511fc60fdab Cr-Commit-Position: refs/heads/master@{#371040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/renderer_host/gpu_message_filter.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jbauman
This is a hack, but probably nice to have some sort of workaround for the ...
4 years, 11 months ago (2016-01-22 19:51:24 UTC) #2
piman
lgtm
4 years, 11 months ago (2016-01-22 20:29:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624633002/1
4 years, 11 months ago (2016-01-22 20:33:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 21:10:56 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 21:13:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25c4ff976aa6b53c29832d0615e40511fc60fdab
Cr-Commit-Position: refs/heads/master@{#371040}

Powered by Google App Engine
This is Rietveld 408576698