[Line Layout API] Change VisibleUnitsTest to use lineLayoutItem()

[Line Layout API] Change VisibleUnitsTest to use lineLayoutItem()

This is part of the ongoing refactoring to make clients use the line
layout API instead of poking at LayoutObjects directly.

No functional changes.

BUG=499321
Committed: https://crrev.com/611438e51f7a97916946ef815907a4cbc7bf05d9
Cr-Commit-Position: refs/heads/master@{#371738}

[dgrogan, 2016-01-22 19:34:32]

dgrogan@chromium.org changed reviewers:
+ pilgrim@chromium.org

[dgrogan, 2016-01-22 19:34:32]

Mark, could you sanity check this tiny patch?

Am I doing the right thing? Namely, make InlineBox::layoutObject() private and
see what doesn't compile. I think that's what you said but am not certain.

What about LineLayoutItem::operator LayoutObject*()? It looks like that also has
to go away before we call this bug done?

Is either of those a higher priority than the other?

Perhaps this crrev isn't the best place to discuss so feel free to respond via
your channel of choice :)

[pilgrim_google, 2016-01-22 19:42:04]

On 2016/01/22 at 19:34:32, dgrogan wrote:
> Mark, could you sanity check this tiny patch?

Looks good. Maybe update the CL description to something a bit more informative
for people who come in blind later and don't know the whole backstory? I also
try to include the phrase "no functional changes" for the good of people
bisecting in the future. Refactoring gets you a lot of "hey the sky is falling
and the bisect said it might be your fault" emails.

> 
> Am I doing the right thing? Namely, make InlineBox::layoutObject() private and
see what doesn't compile. I think that's what you said but am not certain.
> 

Yes.

> What about LineLayoutItem::operator LayoutObject*()? It looks like that also
has to go away before we call this bug done?

Yes, we need to deal with that soon.

> 
> Is either of those a higher priority than the other?
> 

Not really.

[dgrogan, 2016-01-22 22:08:44]

Description was changed from

==========
[Line Layout API] Change VisibleUnitsTest to use lineLayoutItem()

There was just one instance of layoutObject()

BUG=499321
==========

to

==========
[Line Layout API] Change VisibleUnitsTest to use lineLayoutItem()

This is part of the ongoing refactoring to make clients use the line
layout API instead of poking at LayoutObjects directly.

No functional changes.

BUG=499321
==========

[dgrogan, 2016-01-22 22:09:36]

dgrogan@chromium.org changed reviewers:
+ leviw@chromium.org

[dgrogan, 2016-01-22 22:09:36]

(Description updated)

Thanks for looking.

Levi, could you review this patch?

[leviw_travelin_and_unemployed, 2016-01-27 04:20:28]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2016-01-27 04:20:28]

lgtm

[commit-bot: I haz the power, 2016-01-27 04:21:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1624593003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1624593003/1

[commit-bot: I haz the power, 2016-01-27 05:27:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 05:28:53]

Description was changed from

==========
[Line Layout API] Change VisibleUnitsTest to use lineLayoutItem()

This is part of the ongoing refactoring to make clients use the line
layout API instead of poking at LayoutObjects directly.

No functional changes.

BUG=499321
==========

to

==========
[Line Layout API] Change VisibleUnitsTest to use lineLayoutItem()

This is part of the ongoing refactoring to make clients use the line
layout API instead of poking at LayoutObjects directly.

No functional changes.

BUG=499321

Committed: https://crrev.com/611438e51f7a97916946ef815907a4cbc7bf05d9
Cr-Commit-Position: refs/heads/master@{#371738}
==========

[commit-bot: I haz the power, 2016-01-27 05:28:54]

Patchset 1 (id:??) landed as
https://crrev.com/611438e51f7a97916946ef815907a4cbc7bf05d9
Cr-Commit-Position: refs/heads/master@{#371738}