Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1629643002: [Line Layout API] Convert some SVG code to line layout API or shim (Closed)

Created:
4 years, 11 months ago by dgrogan
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pilgrim_google, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@3_api_visible_units_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Line Layout API] Convert some SVG code to line layout API or shim Classes outside of core/layout/ that need a reference to an InlineBox's layoutObject must currently use the API-busting shim we've set up to get a reference to a LineLayoutItem's underlying layoutObject. Some references can simply be changed to lineLayoutItem() directly, where the line layout API already provides access to the methods used. There are no functional changes. BUG=499321 Committed: https://crrev.com/9bbb45c62ed9853ef50fc418861ee222a3714fbe Cr-Commit-Position: refs/heads/master@{#371740}

Patch Set 1 #

Patch Set 2 : layoutObjectFrom -> constLayoutObjectFrom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootInlineBoxPainter.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
dgrogan
Levi, could you review this?
4 years, 11 months ago (2016-01-23 01:40:14 UTC) #2
dgrogan
Levi, are you waiting for Mark to look?
4 years, 11 months ago (2016-01-27 02:55:53 UTC) #5
leviw_travelin_and_unemployed
No sorry. I was traveling and Monday Tuesday was a holiday in Australia, where I ...
4 years, 11 months ago (2016-01-27 03:59:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1629643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1629643002/60001
4 years, 11 months ago (2016-01-27 04:23:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 11 months ago (2016-01-27 05:35:50 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 05:37:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bbb45c62ed9853ef50fc418861ee222a3714fbe
Cr-Commit-Position: refs/heads/master@{#371740}

Powered by Google App Engine
This is Rietveld 408576698