chrome/chrome_browser.gypi - Issue 1624573004: Rename webusb_permission_bubble.mojom and move it to //content/public

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1624573004: Rename webusb_permission_bubble.mojom and move it to //content/public (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed content/content_common_mojo_bindings.gyp again Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 0ba9fbc8590e8952e07369618a2ceb8139c3f7de..b7bd1717585407f0c448d09a56709e970dd4bc52 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1354,8 +1354,8 @@

'browser/upgrade_detector.h',

'browser/usb/usb_chooser_bubble_delegate.cc',

'browser/usb/usb_chooser_bubble_delegate.h',

- 'browser/usb/web_usb_permission_bubble.cc',

- 'browser/usb/web_usb_permission_bubble.h',

+ 'browser/usb/web_usb_permission_request.cc',

+ 'browser/usb/web_usb_permission_request.h',

'chrome_browser_win_sources': [

'browser/first_run/try_chrome_dialog_view.cc',

@@ -3314,6 +3314,7 @@

'../components/components.gyp:webusb',

'../components/components_resources.gyp:components_resources',

'../content/app/resources/content_resources.gyp:content_resources',

+ '../content/content_common_mojo_bindings.gyp:content_common_mojo_bindings',

jam 2016/01/27 23:36:51 chrome/browser shouldn't depend on it. it should g

juncai 2016/01/28 21:08:32 https://code.google.com/p/chromium/codesearch#chro

'../device/core/core.gyp:device_core',

'../device/devices_app/devices_app.gyp:devices_app_public_cpp',

'../device/devices_app/devices_app.gyp:devices_app_public_cpp_factory',

« no previous file with comments | « chrome/browser/usb/web_usb_permission_request.cc ('k') | components/webusb.gypi » ('j') | content/renderer/usb/DEPS » ('J')