Remove XP port from Blink LayoutTest related scripts.

Remove XP port from Blink LayoutTest related scripts.

Fixing up unit tests was somewhat complex due to XP being
used as a key test case throughout. We have essentially
updated the unit tests here to treat Win7 as the new XP,
and Win10 the way Win7 was previously.

Also remove dead ALL_BASELINE_VARIANTS constant and
accessor methods, and document the one remaining
(used by queries_unittest.py) for subsequent cleanup.

BUG=581240
Committed: https://crrev.com/a9c81551ff16474933241739d27cd3a16df3485b
Cr-Commit-Position: refs/heads/master@{#371701}

[wkorman, 2016-01-27 00:32:50]

Description was changed from

==========
Remove XP from Blink LayoutTest related scripts.

BUG=581240
==========

to

==========
Remove XP port from Blink LayoutTest related scripts.

Fixing up unit tests was somewhat complex due to XP being
used as a key test case throughout. We have essentially
updated the unit tests here to treat Win7 as the new XP,
and Win10 the way Win7 was previously.

Also remove dead ALL_BASELINE_VARIANTS constant and
accessor methods, and document the one remaining
(used by queries_unittest.py) for subsequent cleanup.

BUG=581240
==========

[wkorman, 2016-01-27 00:40:23]

wkorman@chromium.org changed reviewers:
+ dpranke@chromium.org, ojan@chromium.org, pdr@chromium.org

[wkorman, 2016-01-27 00:41:46]

I'd like to remove Vista (and Precise, if we confirm doing so is
reasonable) in a separate change.

[pdr., 2016-01-27 00:50:56]

This is very difficult to review :( I went through every line and verified
there's nothing crazy going on, for what it's worth.

How hard would it be to rewrite these tests with MockOS1, MockOS2, etc, so that
this process is less painful in the near future when we roll linux or when the
next mac port is released?

[Dirk Pranke, 2016-01-27 00:57:35]

On 2016/01/27 00:50:56, pdr wrote:
> This is very difficult to review :( I went through every line and verified
> there's nothing crazy going on, for what it's worth.
> 
> How hard would it be to rewrite these tests with MockOS1, MockOS2, etc, so
that
> this process is less painful in the near future when we roll linux or when the
> next mac port is released?

Actually, a lot of these unit tests are already using "fake" data (the stuff
defined in the test port 
is separate from the stuff defined in the non-test ports). This is why you can
also see references
to "leopard" even though we don't still support 10.5.

But, that is admittedly not obvious. If you were to use MockOS1, MockOS2, the
downside is that
you would lose the easy frame of reference, but maybe you could make up data in
some way that
that wouldn't be a big deal.

Aside from all of that, this change lgtm.

You can't drop Precise yet, since most of our bots are still on Precise.

[blink-reviews, 2016-01-27 01:40:01]

I talked with pdr@ briefly in person, just to recap and re: dpranke@
comment as well, in theory we could have kept 'xp' in the unit tests but I
didn't really think about that before I dove in with guns blazing as it
were. There's some debatable value around having test cases reference
modern still-existing ports/versions which is how I partly justified it.

Also the rebaseline unit tests (indirectly) have a FIXME/TODO about their
using a real PortFactory and the onus is on individual tests to replace it
if they need/want to do so. So, there's some add'l cleanup work we'd need
to do if we really want to have the unit tests use wholly independent data.
Ah, here it is:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

There are ~8400 lines of unit test Python code under just the
webkitpy/layout_tests directory.

The good news is the existing tests prevented me from checking in at least
one bit of broken logic (an incorrect fallback for win7, fixed before I
sent for review).

I think this is a reasonable interim step and as we staff up Blink-Infra we
can look at doing more to improve maintenance.

On Tue, Jan 26, 2016 at 4:50 PM <pdr@chromium.org> wrote:

> This is very difficult to review :( I went through every line and verified
> there's nothing crazy going on, for what it's worth.
>
> How hard would it be to rewrite these tests with MockOS1, MockOS2, etc, so
> that
> this process is less painful in the near future when we roll linux or when
> the
> next mac port is released?
>
> https://codereview.chromium.org/1624373005/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Blink Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-01-27 01:40:01]

I talked with pdr@ briefly in person, just to recap and re: dpranke@
comment as well, in theory we could have kept 'xp' in the unit tests but I
didn't really think about that before I dove in with guns blazing as it
were. There's some debatable value around having test cases reference
modern still-existing ports/versions which is how I partly justified it.

Also the rebaseline unit tests (indirectly) have a FIXME/TODO about their
using a real PortFactory and the onus is on individual tests to replace it
if they need/want to do so. So, there's some add'l cleanup work we'd need
to do if we really want to have the unit tests use wholly independent data.
Ah, here it is:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

There are ~8400 lines of unit test Python code under just the
webkitpy/layout_tests directory.

The good news is the existing tests prevented me from checking in at least
one bit of broken logic (an incorrect fallback for win7, fixed before I
sent for review).

I think this is a reasonable interim step and as we staff up Blink-Infra we
can look at doing more to improve maintenance.

On Tue, Jan 26, 2016 at 4:50 PM <pdr@chromium.org> wrote:

> This is very difficult to review :( I went through every line and verified
> there's nothing crazy going on, for what it's worth.
>
> How hard would it be to rewrite these tests with MockOS1, MockOS2, etc, so
> that
> this process is less painful in the near future when we roll linux or when
> the
> next mac port is released?
>
> https://codereview.chromium.org/1624373005/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Blink Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[wkorman, 2016-01-27 02:16:43]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2016-01-27 02:16:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1624373005/#ps60001
(title: "Sync to head.")

[commit-bot: I haz the power, 2016-01-27 02:18:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1624373005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1624373005/60001

[commit-bot: I haz the power, 2016-01-27 03:19:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-27 03:20:05]

Description was changed from

==========
Remove XP port from Blink LayoutTest related scripts.

Fixing up unit tests was somewhat complex due to XP being
used as a key test case throughout. We have essentially
updated the unit tests here to treat Win7 as the new XP,
and Win10 the way Win7 was previously.

Also remove dead ALL_BASELINE_VARIANTS constant and
accessor methods, and document the one remaining
(used by queries_unittest.py) for subsequent cleanup.

BUG=581240
==========

to

==========
Remove XP port from Blink LayoutTest related scripts.

Fixing up unit tests was somewhat complex due to XP being
used as a key test case throughout. We have essentially
updated the unit tests here to treat Win7 as the new XP,
and Win10 the way Win7 was previously.

Also remove dead ALL_BASELINE_VARIANTS constant and
accessor methods, and document the one remaining
(used by queries_unittest.py) for subsequent cleanup.

BUG=581240

Committed: https://crrev.com/a9c81551ff16474933241739d27cd3a16df3485b
Cr-Commit-Position: refs/heads/master@{#371701}
==========

[commit-bot: I haz the power, 2016-01-27 03:20:06]

Patchset 4 (id:??) landed as
https://crrev.com/a9c81551ff16474933241739d27cd3a16df3485b
Cr-Commit-Position: refs/heads/master@{#371701}