third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py - Issue 1624373005: Remove XP port from Blink LayoutTest related scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

Issue 1624373005: Remove XP port from Blink LayoutTest related scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync to head. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

index c703fc98f70da861292321c99123ebc0561ec097..6a60043e9720aad8371c1f8ae03c82379f47687c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

@@ -72,12 +72,11 @@ class FactoryTest(unittest.TestCase):

# operating system, whereas host!=target for Android.

def test_win(self):

- self.assert_port(port_name='win-xp', cls=win.WinPort)

self.assert_port(port_name='win-win7', cls=win.WinPort)

self.assert_port(port_name='win-win10', cls=win.WinPort)

- self.assert_port(port_name='win', os_name='win', os_version='xp',

+ self.assert_port(port_name='win', os_name='win', os_version='win7',

cls=win.WinPort)

- self.assert_port(port_name='chromium', os_name='win', os_version='xp',

+ self.assert_port(port_name='chromium', os_name='win', os_version='win7',

cls=win.WinPort)

def test_unknown_specified(self):